Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROPOSAL] Reduce the number of approvers required in this repo to 1 #179

Closed
dblock opened this issue Mar 28, 2024 · 4 comments
Closed

[PROPOSAL] Reduce the number of approvers required in this repo to 1 #179

dblock opened this issue Mar 28, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@dblock
Copy link
Member

dblock commented Mar 28, 2024

What/Why

What are you proposing?

Currently the number of approvers required to merge a pull request in this repo is 2.

What problems are you trying to solve?

This affects velocity unnecessarily. This repo doesn't have production impact and any potential mistake is easily undone.

Screenshot 2024-03-28 at 9 25 05 AM

#168 (comment)

What is the developer experience going to be?

Only 1 approver required instead of 2 for PRs.

What will it take to execute?

If a majority of existing maintainers can +1 I'll lower this number.
@dblock
Copy link
Member Author

dblock commented Mar 28, 2024

@shyim @VachaShah @harshavamsi yes?

@dblock dblock added enhancement New feature or request and removed untriaged labels Mar 28, 2024
@shyim
Copy link
Collaborator

shyim commented Mar 28, 2024

I would say yes 👍

@VachaShah
Copy link
Collaborator

Sorry I missed this! Yes 👍🏼

@dblock
Copy link
Member Author

dblock commented Apr 18, 2024

Thanks, I made the change in settings.

@dblock dblock closed this as completed Apr 18, 2024
@dblock dblock mentioned this issue Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dblock @shyim @VachaShah