Generated Endpoints Using OpenSearch API Specifications: Phase I #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: saimedhi <saimedhi@amazon.com>
saimedhi
requested review from
VachaShah,
dblock,
harshavamsi and
shyim
as code owners
saimedhi
commented
Jun 20, 2024
| @@ -282,7 +282,7 @@ private function extractUrl(array $paths): string | |||
| ); | |||
| $this->addNamespace('OpenSearch\Common\Exceptions\RuntimeException'); | |||
| } else { | |||
| $params .= sprintf("%s\$%s = \$this->%s ?? null;\n", $tab8, $part, $part); | |||
| $params .= sprintf("%s\$%s = \$this->%s ?? null;", $tab8, $part, $part); | |||
There was a problem hiding this comment.
-
A minor fix is done for the generator here.
-
Apart from that, all other changes are generated using util/GenerateEndpoints.php. Only endpoints with generated code equivalent to the existing code are included in this PR. Endpoints that are not accurately generated will be addressed in follow-up PRs.
dblock
approved these changes
Jun 20, 2024
| @@ -24,6 +24,9 @@ | |||
| use OpenSearch\Common\Exceptions\RuntimeException; | |||
| use OpenSearch\Endpoints\AbstractEndpoint; | |||
|
|
|||
| /** | |||
| * NOTE: This file is autogenerated using util/GenerateEndpoints.php | |||
| */ | |||
There was a problem hiding this comment.
These should probably go on top of the file before use and have a WARNING not to update by hand with instructions of how to update via generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Related to #97
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.