[WIP] Upgrading guzzle. #219
Conversation
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
| { | ||
| $response = null; | ||
| $async = isset($options['client']['future']) ? $options['client']['future'] : null; | ||
| if (is_null($async) || $async === false) { | ||
| do { | ||
| $result = $result->wait(); | ||
| } while ($result instanceof FutureArrayInterface); | ||
| } while ($result instanceof Promise); | ||
| } | ||
| return $result; |
There was a problem hiding this comment.
Changing this return type from FutureArrayInterface|array (callable|array was wrong) to Promise|array will break BC for projects using the future client option to run in async mode as it changes the return type for them.
However, as the generated code does not give access to those options to the projects using them (generated endpoints class are the ones able to configure options), it seems like Client::request() is the only method actually allowing to actually run async. So maybe all the async support is a bunch of dead code.
There was a problem hiding this comment.
Indeed.
This change is a bit over my head and I have made no to slow progress. If someone (you?) wants to take it over and complete it, it would be amazing.
|
I suggest closing this in favor of #233 as supporting any PSR-18 client is better than forcing to use Guzzle (in a Symfony project, devs will likely want to use |
Description
Upgrades Guzze and removes RingHTTP.
What works:
samples, runcomposer run index.What doesn't work:
Next:
Issues Resolved
Closes #216.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.