Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: build OpenSearch with the correct Java/Gradle combination. #234

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Oct 24, 2024

Description

Fixes CI.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock force-pushed the fix-ci branch 2 times, most recently from 43abe11 to da798ec Compare October 24, 2024 14:33
@shyim
Copy link
Collaborator

shyim commented Oct 24, 2024

Maybe we should make a composite action inside Opensearch org, so all use the same configuration 🤔

@dblock dblock force-pushed the fix-ci branch 2 times, most recently from b35afca to f916be1 Compare October 24, 2024 14:36
@dblock
Copy link
Member Author

dblock commented Oct 24, 2024

Maybe we should make a composite action inside Opensearch org, so all use the same configuration 🤔

Yes, it's a good idea, open an issue in https://github.com/opensearch-project/opensearch-clients? I'll finish fixing this one though here just to get us unblocked.

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock marked this pull request as ready for review October 24, 2024 14:47
@dblock
Copy link
Member Author

dblock commented Oct 24, 2024

@shyim this is ready to review/merge

@dblock dblock mentioned this pull request Oct 24, 2024
3 tasks
@shyim shyim merged commit 2518f02 into opensearch-project:main Oct 24, 2024
59 checks passed
@dblock dblock deleted the fix-ci branch October 24, 2024 15:36
@shyim
Copy link
Collaborator

shyim commented Oct 24, 2024

Thanks for your time! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants