fix: reusage of parameters #292
Merged
+58
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyim
requested review from
VachaShah,
dblock,
harshavamsi,
saimedhi and
kimpepper
as code owners
shyim
force-pushed
the
fix-reuse-of-parameters
branch
from
5af159d to
a975abc
Compare
Signed-off-by: Soner Sayakci <s.sayakci@gmail.com>
shyim
force-pushed
the
fix-reuse-of-parameters
branch
from
a975abc to
bf1dde0
Compare
|
We should tag a new release after this as it's pretty broken right now |
kimpepper
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we don't clone endpoints anymore. we keep some set variables between multiple calls. I restored the previous behaviour and added a test. I think we should refactor it out in future PRs
Issues Resolved
Closes #289 , #284
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.