Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the document BUILDING.md: opensearch.opensearchplugin add groupID field to org.opensearch.plugin #162

Closed
prudhvigodithi opened this issue Aug 29, 2022 · 3 comments
Assignees
Labels
v2.4.0 'Issues and PRs related to version v2.4.0'

Comments

@prudhvigodithi
Copy link
Contributor

prudhvigodithi commented Aug 29, 2022

Description

Update the document BUILDING.md
The configuration modification for the gradle plugin opensearch.opensearchplugin to make sure the groupId is added as org.opensearch.plugin to the publication pluginZip inside the build.gradle file.

Related META issue

Part of: opensearch-project/opensearch-build#2521
From solution: opensearch-project/OpenSearch#3692

Current Behavior

The opensearch.opensearchplugin uses the default setting for groupId as org.opensearch.plugin, this when extended with open source community, it should be feasible to ammend the groupId as per required, hence for opensearch plugins the groupId should be mentioned as org.opensearch.plugin to make sure the opensearch plugins are published to this groupID and for other generic uses this can be extended to the custom groupId.

Expected Behavior

Once the groupId is added as org.opensearch.plugin to the publication pluginZip inside the build.gradle file, the plugin zips should continue to be published to the existing groupID.

Proposed solution

Solution from the PR: opensearch-project/OpenSearch#3692

@prudhvigodithi prudhvigodithi changed the title opensearch.opensearchplugin add groupID field to org.opensearch.plugin Update the document BUILDING.md: opensearch.opensearchplugin add groupID field to org.opensearch.plugin Aug 29, 2022
@prudhvigodithi prudhvigodithi added the v2.4.0 'Issues and PRs related to version v2.4.0' label Aug 29, 2022
@prudhvigodithi
Copy link
Contributor Author

prudhvigodithi commented Oct 21, 2022

Hey @lukas-vlcek when you get a chance can you please update the document with the latest changes from your PR?
Thank you
@dblock @bbarani @reta

@lukas-vlcek
Copy link
Contributor

@prudhvigodithi Please see #175

@prudhvigodithi
Copy link
Contributor Author

Thanks @lukas-vlcek closing this issue and related PR is merged #175.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

No branches or pull requests

2 participants