Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize processes across all plugins #41

Closed
12 of 17 tasks
saratvemulapalli opened this issue Jun 8, 2021 · 9 comments
Closed
12 of 17 tasks

Standardize processes across all plugins #41

saratvemulapalli opened this issue Jun 8, 2021 · 9 comments
Labels

Comments

@saratvemulapalli
Copy link
Member

saratvemulapalli commented Jun 8, 2021

Here is a meta issue for all plugins to track items which have to be taken care of between RC1 and GA for all the plugins.
Create an issue for the plugin you own and take care of the checklist.

@saratvemulapalli saratvemulapalli added Meta enhancement New feature or request labels Jun 8, 2021
@dblock
Copy link
Member

dblock commented Jun 9, 2021

I propose we split these into separate issues, and label them for v1.0.0? This way we can track a bunch of things under a label.

Add consistent version labels.

@saratvemulapalli saratvemulapalli changed the title Issue to track all items needed for GA Issue to track all items needed to be standardized for GA Jun 9, 2021
@saratvemulapalli
Copy link
Member Author

saratvemulapalli commented Jun 9, 2021

I understand the value of having multiple issues and can be tracked using a label. Would it be cumbersome for folks to track all the items to put thoughts into?

@dblock
Copy link
Member

dblock commented Jun 9, 2021

I understand the value of having multiple issues and can be tracked using a label. Would it be cumbersome for folks to track all the items to put thoughts into?

I do like having a meta issue, but an issue is an issue is an issue, we probably don't want to mix discussions and PRs

... I don't feel strongly about any of this

@dblock dblock removed the enhancement New feature or request label Jun 9, 2021
@dblock dblock changed the title Issue to track all items needed to be standardized for GA Standardize processes across all plugins Jun 9, 2021
@dblock dblock added the v1.0.0 OpenSearch 1.0 Release label Jun 9, 2021
@ohltyler
Copy link
Member

ohltyler commented Jun 9, 2021

@saratvemulapalli @dblock another thing - now that Dashboards defaults to kebab-case for installed plugins, shall we finalize naming conventions for the build zips for Dashboards plugins?

Current zip convention: <pluginName>Dashboards-x.zip (e.g., anomalyDetectionDashboards-1.0.0.0-rc1.zip`)

New ideas:
Option 1: identical to existing name, but in kebab-case: <plugin-name>-dashboards-x.zip (e.g., anomaly-detection-dashboards-1.0.0.0-rc1.zip.
Option 2: same convention as OpenSearch plugins, but replacing opensearch with dashboards: dashboards-<plugin-name>-x.zip (e.g., dashboards-anomaly-detection-1.0.0.0-rc1.zip (this was mentioned here as well)

Any thoughts here? I think either make sense. Option 1 will keep consistency with the existing plugin IDs which are following the camelcase convention of <pluginNameDashboards> (note that this could be changed to something like dashboardsPluginName, but will require more code changes & testing). Option 2 will keep consistency with OpenSearch plugin names, in regards to the zips at least.

@dblock
Copy link
Member

dblock commented Jun 10, 2021

@ohltyler I opened #47 (you can just open issues next time too!) will add comments there

@anirudha
Copy link

anirudha commented Jun 24, 2021

Looking ahead, I would like it if these issues were broken down into individual issues. Individual issues so much easier to track

@dblock
Copy link
Member

dblock commented Jun 24, 2021

Looking ahead, I would like it if these issues were broken down into individual issues. Individual issues so much easier to track

They are, aren't they?

@anirudha
Copy link

anirudha commented Jun 24, 2021

I understand the value of having multiple issues and can be tracked using a label. Would it be cumbersome for folks to track all the items to put thoughts into?

I do like having a meta issue, but an issue is an issue is an issue, we probably don't want to mix discussions and PRs

... I don't feel strongly about any of this

we couldnt confirm if everything here was covered as separate issue. I saw a few. So now we had to see this meta issue plus a few others.

No worries, will track only the issues in each repo. thanks!

@dblock
Copy link
Member

dblock commented Apr 18, 2022

I'm going to close this, we've done most of it, and original intent was just to collect work up to 1.0 GA.

@dblock dblock closed this as completed Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants