-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding broken links check using github actions #54
Adding broken links check using github actions #54
Conversation
1baaab9
to
a1f550f
Compare
Thanks @VachaShah for the change. I see this only runs a checker for Markdown files. This works for opensearch-plugins repo, but we would want to standardize this for all the plugins and OpenSearch repo's. |
@saratvemulapalli This checker only checks the md files, I can look for something that runs a check for all files. |
a1f550f
to
aad8e31
Compare
@saratvemulapalli I added another github action which can check for all kinds of text files. It has run on this PR as well. I also ran it on my test repo on a push and also created a PR against main which had a broken link. LMK if this works for our use case. |
aad8e31
to
d7279a1
Compare
Thanks @VachaShah for this. This is great. Can you add a doc in this repo on how plugins and other repositories can use it? |
Thank you @saratvemulapalli. I have added the documentation to this PR. |
Thanks @VachaShah for adding the documentation. I would rather have it in https://github.com/opensearch-project/opensearch-plugins/blob/main/CONVENTIONS.md with a new top level section called Plugins Standards. I am leaning towards the latter, as I see most of the items in #41 will go in here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm with @saratvemulapalli on the fact that if we put this in release notes, it gets read too late.
RELEASE_NOTES.md
Outdated
See [release-drafter](https://github.com/release-drafter/release-drafter) for more information. | ||
|
||
### Check for broken links |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize Broken Links to match other titles.
Signed-off-by: Vacha Shah <vachshah@amazon.com>
370f0cc
to
1039799
Compare
@saratvemulapalli @dblock I have added a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment. Everything looks good to me.
README.md
Outdated
- [Contributing](#contributing) | ||
- [Standards](#standards) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go under OpenSearch Plugins like a subsection. Just like any other topic here.
The main header is for something which talks about this repository itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated this in the README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @VachaShah !
Just address the minor comment and merge the changes.
Signed-off-by: Vacha Shah <vachshah@amazon.com>
1039799
to
a1ccb0b
Compare
Signed-off-by: Vacha Shah vachshah@amazon.com
Description
This PR adds a github action for checking broken links in the markdown files. This check is triggered on PRs and push.
###Testing
I tested this action on a dummy repo https://github.com/VachaShah/TestGithubActions/actions by adding a broken link in some text files, the action failed with the broken link. Also, I have verified by creating a PR with some broken links in files.
Issues Resolved
#29
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.