Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a section for license and license headers #48

Merged
merged 6 commits into from
Jun 18, 2021
Merged

Conversation

saratvemulapalli
Copy link
Member

@saratvemulapalli saratvemulapalli commented Jun 10, 2021

Signed-off-by: Sarat Vemulapalli vemulapallisarat@gmail.com

Description

Adding a section for license and license headers for plugins and guidance on how to use them in opensearch-project.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@saratvemulapalli saratvemulapalli requested a review from dblock June 10, 2021 15:32
@saratvemulapalli
Copy link
Member Author

cc: @ohltyler I could not add you to the review (probably some permissions), so tagging you here.

@ohltyler
Copy link
Member

LGTM, although it doesn't mean anything 😄

@dblock
Copy link
Member

dblock commented Jun 10, 2021

Are we better off putting this into its own "Licenses and License Headers" section? This is an important topic for plugins.

@saratvemulapalli
Copy link
Member Author

Are we better off putting this into its own "Licenses and License Headers" section? This is an important topic for plugins.

I kind of agree. It's probably bigger topic rather than just being in a FAQ.
I'll add a main section to Readme.md.

@dblock
Copy link
Member

dblock commented Jun 10, 2021

Are we better off putting this into its own "Licenses and License Headers" section? This is an important topic for plugins.

I kind of agree. It's probably bigger topic rather than just being in a FAQ.
I'll add a main section to Readme.md.

We've been creating files like CONVENTIONS :)

@dblock
Copy link
Member

dblock commented Jun 14, 2021

Let's also add a HowTo here/somewhere on how to do it with links to examples like opensearch-project/job-scheduler#36

@dblock
Copy link
Member

dblock commented Jun 14, 2021

@ketanv3

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@saratvemulapalli saratvemulapalli changed the title Adding FAQs and guidance on license headers for plugins. Adding a section for license and license headers Jun 16, 2021
@saratvemulapalli
Copy link
Member Author

saratvemulapalli commented Jun 16, 2021

Are we better off putting this into its own "Licenses and License Headers" section? This is an important topic for plugins.

I kind of agree. It's probably bigger topic rather than just being in a FAQ.
I'll add a main section to Readme.md.

We've been creating files like CONVENTIONS :)

Thanks @dblock. Added a new section for this. And hopefully @ketanv3 can add the license check automation documentation to this section.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things ...

LICENSES_AND_LICENSE_HEADERS.md Outdated Show resolved Hide resolved
LICENSES_AND_LICENSE_HEADERS.md Outdated Show resolved Hide resolved
LICENSES_AND_LICENSE_HEADERS.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@saratvemulapalli saratvemulapalli merged commit 677620f into main Jun 18, 2021
@saratvemulapalli saratvemulapalli deleted the plugin-faqs branch June 18, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants