-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a section for license and license headers #48
Conversation
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
cc: @ohltyler I could not add you to the review (probably some permissions), so tagging you here. |
LGTM, although it doesn't mean anything 😄 |
Are we better off putting this into its own "Licenses and License Headers" section? This is an important topic for plugins. |
I kind of agree. It's probably bigger topic rather than just being in a FAQ. |
We've been creating files like CONVENTIONS :) |
Let's also add a HowTo here/somewhere on how to do it with links to examples like opensearch-project/job-scheduler#36 |
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Thanks @dblock. Added a new section for this. And hopefully @ketanv3 can add the license check automation documentation to this section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things ...
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli vemulapallisarat@gmail.com
Description
Adding a section for license and license headers for plugins and guidance on how to use them in opensearch-project.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.