Fixes a suspicious setattr that should be taking an Any #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
VachaShah,
harshavamsi,
axeoman,
deztructor,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
=======================================
Coverage 71.98% 71.98%
=======================================
Files 89 89
Lines 7934 7934
=======================================
Hits 5711 5711
Misses 2223 2223 ☔ View full report in Codecov by Sentry. |
Signed-off-by: dblock <dblock@amazon.com>
…t, variable has type Double) [assignment] Signed-off-by: dblock <dblock@amazon.com>
dblock
changed the title
harshavamsi
approved these changes
Nov 17, 2023
|
|
||
| def test_save_double(mock_client: Any) -> None: | ||
| class MyDocumentWithDouble(MyDoc): | ||
| a_double: Union[float, field.Double] = field.Double() |
There was a problem hiding this comment.
why is this only float and not field.Float?
There was a problem hiding this comment.
One is a primitive type and the other one is a field.
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
…roject#604) * Fix invalid value type. Signed-off-by: dblock <dblock@amazon.com> * Workaround Incompatible types in assignment (expression has type float, variable has type Double) [assignment] Signed-off-by: dblock <dblock@amazon.com> --------- Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: roma2023 <romasaparhan19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a suspicious
setattrthat should be taking anAny.The
Doublesupports__setattr__assignment with a float, but I am not sure how to express that in the actualDoubleclass.Issues Resolved
Related to #602.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.