-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced service time metrics to OpenSearch-Py client. #689
Introduced service time metrics to OpenSearch-Py client. #689
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
==========================================
- Coverage 72.14% 72.06% -0.08%
==========================================
Files 89 90 +1
Lines 7945 8009 +64
==========================================
+ Hits 5732 5772 +40
- Misses 2213 2237 +24 ☔ View full report in Codecov by Sentry. |
I'm unsure about my changes to async connections. I've tested them, but I'm uncertain if I've covered all cases. Let's start by applying these changes for requests and urllib3 connections first. For async connections, I'll need to review whether a similar approach to sync connections is suitable or if we should utilize something like aiohttptraceconfig. I've created a copy of my tested and functional changes, which include async connections. However, I'm streamlining this PR to concentrate solely on sync connections. |
dd23f24
to
aa3291c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start. The if calculate_service_time:
is the anti-pattern we need to fix here and make it more object-oriented. Define a generic Metrics
interface with methods such as request_start
, and a specific implementation for it using Events
, e.g. EventsMetrics
. See below.
91dc132
to
f6c900e
Compare
ee8ed35
to
0de0c4b
Compare
Signed-off-by: saimedhi <saimedhi@amazon.com>
0de0c4b
to
5ea57d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better. Needs tests and some more changes.
Description
Introduced service time metrics to OpenSearch-Py client.
Issues Resolved
#678
Guide and Tests need to be added for this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.