Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to 2.5.0 #703

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Bump version to 2.5.0 #703

merged 2 commits into from
Mar 22, 2024

Conversation

saimedhi
Copy link
Collaborator

Description

Bump version to 2.5.0

Issues Resolved

Closes #695

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saimedhi
Bump version to 2.5.0
5f92ae4 
Signed-off-by: saimedhi <saimedhi@amazon.com>
@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.97%. Comparing base (25db5d5) to head (5ac26d2).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
- Coverage   72.14%   71.97%   -0.17%     
==========================================
  Files          89       91       +2     
  Lines        7945     8011      +66     
==========================================
+ Hits         5732     5766      +34     
- Misses       2213     2245      +32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saimedhi
Copy link
Collaborator Author

saimedhi commented Mar 22, 2024 •
edited
Loading

@VachaShah, @dblock, @harshavamsi please take a look.

Also, can you confirm if the version specified in .github/workflows/unified-release.yml and opensearchpy/_version.py is correct as 2.5.0?

harshavamsi
harshavamsi previously approved these changes Mar 22, 2024
View reviewed changes
@harshavamsi
Copy link
Collaborator

Link checker looks like a bug, should be fine.

@dblock
Copy link
Member

dblock commented Mar 22, 2024

Merge?

@saimedhi
Copy link
Collaborator Author

Merge?

@dblock, should I update the version of opensearch-py in the following locations?

  1. benchmarks/poetry.lock
  2. samples/poetry.lock

@saimedhi
Bump version to 2.5.0
5ac26d2 
Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi
Copy link
Collaborator Author

saimedhi commented Mar 22, 2024 •
edited
Loading

Merge?

@dblock, should I update the version of opensearch-py in the following locations?

  1. benchmarks/poetry.lock
  2. samples/poetry.lock

Ready for review

@VijayanB
Copy link
Member

VijayanB commented Mar 22, 2024 •
edited
Loading

@VachaShah @dblock @harshavamsi Can this be merged? Looking forward for 2.5. This will unblock OSB #695

@harshavamsi harshavamsi merged commit f226570 into opensearch-project:main Mar 22, 2024
53 of 55 checks passed
AbitraryYu pushed a commit to AbitraryYu/opensearch-py that referenced this pull request Apr 22, 2024
@saimedhi @AbitraryYu
Bump version to 2.5.0 (opensearch-project#703)
39ea9db 
* Bump version to 2.5.0

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Bump version to 2.5.0

Signed-off-by: saimedhi <saimedhi@amazon.com>

---------

Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: AbitraryYu <nikkoyhc@gmail.com>
dblock pushed a commit to dblock/opensearch-py that referenced this pull request Aug 15, 2024
@saimedhi @dblock
Bump version to 2.5.0 (opensearch-project#703)
24dd1ba 
* Bump version to 2.5.0

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Bump version to 2.5.0

Signed-off-by: saimedhi <saimedhi@amazon.com>

---------

Signed-off-by: saimedhi <saimedhi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VijayanB VijayanB VijayanB approved these changes

@harshavamsi harshavamsi harshavamsi approved these changes

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@axeoman axeoman Awaiting requested review from axeoman axeoman is a code owner

@Shephalimittal Shephalimittal Awaiting requested review from Shephalimittal Shephalimittal is a code owner

@florianvazelle florianvazelle Awaiting requested review from florianvazelle florianvazelle is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New opensearch py release
4 participants
@saimedhi @harshavamsi @dblock @VijayanB