Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permission to the release workflow #706

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Mar 22, 2024

Description

Add permission to the release workflow

Issues Resolved

Release workflow failed to create github issue for manual approval.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

zelinh added 2 commits March 22, 2024 16:52

Verified

This commit was signed with the committer’s verified signature.
zelinh Zelin Hao
Signed-off-by: Zelin Hao <zelinhao@amazon.com>

Verified

This commit was signed with the committer’s verified signature.
zelinh Zelin Hao
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.97%. Comparing base (f226570) to head (1bd4579).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   71.97%   71.97%           
=======================================
  Files          91       91           
  Lines        8011     8011           
=======================================
  Hits         5766     5766           
  Misses       2245     2245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saimedhi saimedhi merged commit 8a00963 into opensearch-project:main Mar 23, 2024
59 of 68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 23, 2024
* Add permission needed for manual approval

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

* Remove codeowner

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

---------

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
(cherry picked from commit 8a00963)
@zelinh
Copy link
Member Author

zelinh commented Mar 23, 2024

Remove the codeowner since he doesn't have write access to this repo anymore.

Unknown owner on line 2: make sure @deztructor exists and has write access to the repository
…@dblock @harshavamsi @axeoman @deztructor @Shephalimittal @saimedhi @florianvazelle

saimedhi pushed a commit that referenced this pull request Mar 23, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Add permission needed for manual approval

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

* Remove codeowner

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

---------

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
(cherry picked from commit 8a00963)

Co-authored-by: Zelin Hao <zelinhao@amazon.com>
AbitraryYu pushed a commit to AbitraryYu/opensearch-py that referenced this pull request Apr 22, 2024
* Add permission needed for manual approval

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

* Remove codeowner

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

---------

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: AbitraryYu <nikkoyhc@gmail.com>
dblock pushed a commit to dblock/opensearch-py that referenced this pull request Aug 15, 2024

Verified

This commit was signed with the committer’s verified signature.
dblock Daniel (dB.) Doubrovkine
* Add permission needed for manual approval

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

* Remove codeowner

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

---------

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.5 skip-changelog Skips changelog verifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants