-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add permission to the release workflow #706
Merged
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
zelinh
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
March 22, 2024 23:58
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #706 +/- ##
=======================================
Coverage 71.97% 71.97%
=======================================
Files 91 91
Lines 8011 8011
=======================================
Hits 5766 5766
Misses 2245 2245 ☔ View full report in Codecov by Sentry. |
saimedhi
approved these changes
Mar 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 23, 2024
* Add permission needed for manual approval Signed-off-by: Zelin Hao <zelinhao@amazon.com> * Remove codeowner Signed-off-by: Zelin Hao <zelinhao@amazon.com> --------- Signed-off-by: Zelin Hao <zelinhao@amazon.com> (cherry picked from commit 8a00963)
Remove the codeowner since he doesn't have write access to this repo anymore.
|
saimedhi
pushed a commit
that referenced
this pull request
Mar 23, 2024
* Add permission needed for manual approval Signed-off-by: Zelin Hao <zelinhao@amazon.com> * Remove codeowner Signed-off-by: Zelin Hao <zelinhao@amazon.com> --------- Signed-off-by: Zelin Hao <zelinhao@amazon.com> (cherry picked from commit 8a00963) Co-authored-by: Zelin Hao <zelinhao@amazon.com>
AbitraryYu
pushed a commit
to AbitraryYu/opensearch-py
that referenced
this pull request
Apr 22, 2024
* Add permission needed for manual approval Signed-off-by: Zelin Hao <zelinhao@amazon.com> * Remove codeowner Signed-off-by: Zelin Hao <zelinhao@amazon.com> --------- Signed-off-by: Zelin Hao <zelinhao@amazon.com> Signed-off-by: AbitraryYu <nikkoyhc@gmail.com>
dblock
pushed a commit
to dblock/opensearch-py
that referenced
this pull request
Aug 15, 2024
* Add permission needed for manual approval Signed-off-by: Zelin Hao <zelinhao@amazon.com> * Remove codeowner Signed-off-by: Zelin Hao <zelinhao@amazon.com> --------- Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add permission to the release workflow
Issues Resolved
Release workflow failed to create github issue for manual approval.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.