Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code generated using new version of OpenAPI specification #722

Closed
wants to merge 5 commits into from
Closed

Code generated using new version of OpenAPI specification #722

wants to merge 5 commits into from

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Apr 17, 2024 •
edited
Loading

Description

Code generated using new version of OpenAPI specification

Issues Resolved

Closes #636
Closes #474

Before reviewing this PR, please review PR #721. PR #721 contains only the changes made for the generator, without the generated code.

The failing tests have been addressed in opensearch-project/opensearch-api-specification#246.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member

dblock commented Apr 17, 2024 •
edited
Loading

One of the big changes here is that common query_params are repeated all over the place. I suppose we don't have a better idea to represent that? Maybe there can be a shared annotation like @common_query_params (can be a future improvement).

saimedhi and others added 2 commits April 17, 2024 13:53
@saimedhi
Updated code generator to use native OpenAPI specification (#37)
a557565 
Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi
Code generated using native OpenAPI specification
b8ff2cc 
Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi saimedhi closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah will be requested when the pull request is marked ready for review VachaShah is a code owner

@dblock dblock Awaiting requested review from dblock dblock will be requested when the pull request is marked ready for review dblock is a code owner

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi will be requested when the pull request is marked ready for review harshavamsi is a code owner

@axeoman axeoman Awaiting requested review from axeoman axeoman will be requested when the pull request is marked ready for review axeoman is a code owner

@Shephalimittal Shephalimittal Awaiting requested review from Shephalimittal Shephalimittal will be requested when the pull request is marked ready for review Shephalimittal is a code owner

@florianvazelle florianvazelle Awaiting requested review from florianvazelle florianvazelle will be requested when the pull request is marked ready for review florianvazelle is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Tests for Notifications Plugin [FEATURE] Add support for search pipeline APIs
2 participants
@saimedhi @dblock