-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip elements with titles. #777
Conversation
@dblock, Please take a look at the failing tests. Thank you. |
The failure is unrelated caused by opensearch-project/OpenSearch@29a3e2c. The What's the right way to fix this @saimedhi? Where do I remove the fact that these parameters are required and can default to |
|
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
==========================================
+ Coverage 71.95% 73.40% +1.44%
==========================================
Files 91 67 -24
Lines 8001 5339 -2662
==========================================
- Hits 5757 3919 -1838
+ Misses 2244 1420 -824 ☔ View full report in Codecov by Sentry. |
* Skip elements with titles. Signed-off-by: dblock <dblock@amazon.com> * Simplify and just skip by ref. Signed-off-by: dblock <dblock@amazon.com> * Re-generate API spec. Signed-off-by: dblock <dblock@amazon.com> * Do not skip alias tests. Signed-off-by: dblock <dblock@amazon.com> * Actually skip node_id_or_metric. Signed-off-by: dblock <dblock@amazon.com> --------- Signed-off-by: dblock <dblock@amazon.com>
index: Any, | ||
name: Any, | ||
body: Any = None, | ||
index: Any = None, | ||
name: Any = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: This is a breaking change for anybody that were calling the method without naming the arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a miss :(
Care to open a bug, or if you have time fix the code generator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The number of users affected by this is probably limited, but perhaps it's worth calling it out in the release notes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made a bug for it here: #803.
Description
A workaround for the change in opensearch-project/opensearch-api-specification#416 to avoid adding
node_id_or_metric
. With opensearch-project/opensearch-api-specification#434 the only API tests that need to be skipped are those thatcatch
an error (missing index parameters). These fail as expected on the client side.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.