Implement AsyncOpenSearch() parameter ssl_assert_hostname

[merlinz01]

Description

Implements the ssl_assert_hostname parameter for AsyncOpenSearch().

Issues Resolved

Closes #842

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.92%. Comparing base (ba715b9) to head (227fbaa).
Report is 69 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #843      +/-   ##
==========================================
- Coverage   71.95%   70.92%   -1.04%     
==========================================
  Files          91      113      +22     
  Lines        8001     8900     +899     
==========================================
+ Hits         5757     6312     +555     
- Misses       2244     2588     +344     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dblock]

I know it's a fairly trivial change, but we want to make sure someone doesn't break this code in the future, so let's add a test, please?

Mention it somewhere in the user guide in this repo, too.

[dblock]

Fix DCO, rebase please?

[dblock]

CI failed in lint, nox -rs format I think ...

[dblock]

Looks like a legit test failure with a newer Python version?

_ TestAIOHttpConnection.test_nowarn_when_test_uses_https_if_verify_certs_is_off _
self = <test_opensearchpy.test_async.test_connection.TestAIOHttpConnection object at 0x7f8f401a8740>
    async def test_nowarn_when_test_uses_https_if_verify_certs_is_off(self) -> None:
        with warnings.catch_warnings(record=True) as w:
            con = AIOHttpConnection(
                use_ssl=True, verify_certs=False, ssl_show_warn=False
            )
            await con._create_aiohttp_session()
>           assert w == []
E           assert [<warnings.WarningMessage object at 0x7f8f304f7ef0>] == []
E             
E             Left contains one more item: <warnings.WarningMessage object at 0x7f8f304f7ef0>
E             
E             Full diff:
E             - []
E             + [
E             +     <warnings.WarningMessage object at 0x7f8f304f7ef0>,
E             + ]
test_opensearchpy/test_async/test_connection.py:231: AssertionError

[merlinz01]

Testing with Python 3.12 works for me, can you rerun the test?

[dblock]

Testing with Python 3.12 works for me, can you rerun the test?

Failed again, it's not a fluke, there's some warning but the contents don't show up in the log (maybe start there to see the error) https://github.com/opensearch-project/opensearch-py/actions/runs/11846183040/job/33061554546?pr=843.

[merlinz01]

enable_cleanup_closed ignored because https://github.com/python/cpython/pull/118960 is fixed in Python version sys.version_info(major=3, minor=12, micro=7, releaselevel='final', serial=0)

python/cpython#118960

[merlinz01]

OK, so it's a deprecated parameter on aiohttp.TCPConnection starting in Python 3.12.7, I don't think related to these changes. Shall I add a patch for the test onto this PR?

[dblock]

OK, so it's a deprecated parameter on aiohttp.TCPConnection starting in Python 3.12.7, I don't think related to these changes. Shall I add a patch for the test onto this PR?

Yes please, we do want tests to pass :)

[merlinz01]

Thanks @dblock! I don't see where the release schedule for clients is documented, so wondering when this change will be available.

[dblock]

Open an issue to release v. next and I can try to make it happen this coming week.