Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename DenseVector/dense_vector field type to KnnVector/knn_vector #853

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dannynoonan
Copy link

Description

Rename DenseVector field type to KnnVector, in the same vein as opensearch-java PR 524

Issues Resolved

Similar to opensearch-java Issue 437

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.31%. Comparing base (ba715b9) to head (9693557).
Report is 70 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   71.95%   70.31%   -1.64%     
==========================================
  Files          91      125      +34     
  Lines        8001     9299    +1298     
==========================================
+ Hits         5757     6539     +782     
- Misses       2244     2760     +516     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock
Copy link
Member

dblock commented Nov 26, 2024

Thanks.

  1. Sign DCO, git commit --amend -s.
  2. Make sure CI passes (nox -rs format to fix linter).
  3. Add a test. Let's make sure this code actually works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants