Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage collection and reporting #74

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Sep 16, 2022

Description

Adds code coverage collection and reporting.

Issues Resolved

Relates to #73 (but doesn't fully resolve)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@Xtansia Xtansia requested a review from a team as a code owner September 16, 2022 07:55
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@d8e061f). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage        ?   41.20%           
=======================================
  Files           ?       48           
  Lines           ?    27972           
  Branches        ?        0           
=======================================
  Hits            ?    11527           
  Misses          ?    16445           
  Partials        ?        0           
Flag Coverage Δ
integration 41.20% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Xtansia for adding this!

Does the report here cover for both unit and integration tests?

@Xtansia
Copy link
Collaborator Author

Xtansia commented Sep 20, 2022

Thank you @Xtansia for adding this!

Does the report here cover for both unit and integration tests?

@VachaShah There's currently no workflow running the unit tests, I was thinking to add that as a separate PR as there's issue #45 which looks like unit tests might be flakey or expecting some specific setup.

@VachaShah
Copy link
Collaborator

Thank you @Xtansia for adding this!
Does the report here cover for both unit and integration tests?

@VachaShah There's currently no workflow running the unit tests, I was thinking to add that as a separate PR as there's issue #45 which looks like unit tests might be flakey or expecting some specific setup.

Sounds good!

@dblock dblock merged commit 3cd25c7 into opensearch-project:main Sep 20, 2022
@Xtansia Xtansia deleted the feat/codecov branch September 28, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants