Added RuboCop. #165
Merged
Added RuboCop. #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
VijayanB,
jayeshathila,
robsears,
vamshin,
VachaShah,
nhtruong and
harshavamsi
as code owners
Merged
dblock
force-pushed
the
rubocop
branch
7 times, most recently
from
c9e4cfe to
618e8b5
Compare
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
VachaShah
approved these changes
Apr 4, 2023
nhtruong
reviewed
Apr 4, 2023
| @@ -424,14 +433,14 @@ def apply_headers(client, options) | |||
| end | |||
|
|
|||
| def find_value(hash, regex) | |||
| key_value = hash.find { |k,v| k.to_s.downcase =~ regex } | |||
| key_value = hash.find { |k, _v| k.to_s.downcase =~ regex } | |||
| if key_value | |||
| hash.delete(key_value[0]) | |||
| key_value[1] | |||
| end | |||
There was a problem hiding this comment.
(Not relevant to this PR but just a fun thought)
This could be a one-liner :P
hash.delete (hash.keys.find { |k| k.to_s.downcase =~ regex })
Because Hash#delete will also return the value if the key is present, else nil is returned.
There was a problem hiding this comment.
I think a good next step is to actually go through the code, fix rubocop violations instead of ignoring them, and improve things like these!
nhtruong
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added RuboCop, target version is 2.5 which is our minimum Ruby. Ran
rubocop -a ; rubocop --auto-gen-config.I added it at top level. It changed a few files :)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.