Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CODE_GEN] Added remote_store.restore action #176

Merged
merged 5 commits into from
Jul 19, 2023

Conversation

nhtruong
Copy link
Collaborator

@nhtruong nhtruong commented Jul 10, 2023

Description

All files, excepts .rubocop.yml and CHANGELOG.md, were generated by the API generator I'm working on. Once this has been merged, I'll follow up with a PR for the generator into this repo.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

nhtruong added 2 commits July 10, 2023 11:11
Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
@nhtruong nhtruong marked this pull request as ready for review July 10, 2023 17:27
Signed-off-by: Theo Truong <theotr@amazon.com>
dblock
dblock previously approved these changes Jul 12, 2023
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit on the CHANGELOG pls.

CHANGELOG.md Outdated Show resolved Hide resolved
spec/opensearch/api/actions/remote_store/restore_spec.rb Outdated Show resolved Hide resolved
Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
@nhtruong nhtruong requested a review from dblock July 13, 2023 16:36
@nhtruong
Copy link
Collaborator Author

@VachaShah I'm happy with what we've got so far with this generated code. Going to do some refactoring before creating the PR to move the generator here. We can merge this now. Thanks

Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhtruong This looks great! Since this is an experimental API, are there any plans to mark it as such in the client?

@nhtruong
Copy link
Collaborator Author

nhtruong commented Jul 19, 2023

@VachaShah We will need to include this info in the API spec. Something like x-experimental: true. Then the generator will look for that flag to display the warning. Thanks for pointing that out!

Will update this action in a follow-up PR

@nhtruong nhtruong merged commit fc4c4eb into opensearch-project:main Jul 19, 2023
@nhtruong nhtruong deleted the code_gen/pilot branch July 19, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants