-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CODE_GEN] Added remote_store.restore
action
#176
Conversation
Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit on the CHANGELOG pls.
Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
@VachaShah I'm happy with what we've got so far with this generated code. Going to do some refactoring before creating the PR to move the generator here. We can merge this now. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nhtruong This looks great! Since this is an experimental API, are there any plans to mark it as such in the client?
@VachaShah We will need to include this info in the API spec. Something like Will update this action in a follow-up PR |
Description
All files, excepts
.rubocop.yml
andCHANGELOG.md
, were generated by the API generator I'm working on. Once this has been merged, I'll follow up with a PR for the generator into this repo.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.