Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script_score to query DSL #254

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Conversation

quangcap
Copy link
Contributor

@quangcap quangcap commented Jul 4, 2024

Description

Script Score query was added to OpenSearch 2.9 and current query DSL does not support it.
This PR add script_score to query DSL.

Issues Resolved

#253

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Kim Quang Cap added 2 commits July 4, 2024 13:28
Signed-off-by: Kim Quang Cap <kimquangcap@gmail.com>
Signed-off-by: Kim Quang Cap <kimquangcap@gmail.com>
Copy link
Collaborator

@Earlopain Earlopain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Looks good to me apart from some small nits. Can you also add a changelog entry?

lib/opensearch/dsl/search/queries/script_score.rb Outdated Show resolved Hide resolved
lib/opensearch/dsl/search/queries/script_score.rb Outdated Show resolved Hide resolved
Signed-off-by: Kim Quang Cap <kimquangcap@gmail.com>
@quangcap quangcap requested a review from Earlopain July 5, 2024 02:46
Earlopain
Earlopain previously approved these changes Jul 6, 2024
lib/opensearch/dsl/search/queries/script_score.rb Outdated Show resolved Hide resolved
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ES license part should be removed, please?

Signed-off-by: Kim Quang Cap <kimquangcap@gmail.com>
@Earlopain
Copy link
Collaborator

A licence header is still required, that note was just about the Elastic bit. You can look at how license headers currently look like at this file for example: https://github.com/opensearch-project/opensearch-ruby/blob/main/api_generator%2Flib%2Faction.rb

Signed-off-by: Kim Quang Cap <kimquangcap@gmail.com>
@quangcap
Copy link
Contributor Author

quangcap commented Jul 9, 2024

Oh, right! Thanks for guiding me @Earlopain @dblock

@dblock dblock merged commit 280774c into opensearch-project:main Jul 9, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants