-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script_score to query DSL #254
Conversation
Signed-off-by: Kim Quang Cap <kimquangcap@gmail.com>
Signed-off-by: Kim Quang Cap <kimquangcap@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Looks good to me apart from some small nits. Can you also add a changelog entry?
Signed-off-by: Kim Quang Cap <kimquangcap@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ES license part should be removed, please?
Signed-off-by: Kim Quang Cap <kimquangcap@gmail.com>
A licence header is still required, that note was just about the Elastic bit. You can look at how license headers currently look like at this file for example: https://github.com/opensearch-project/opensearch-ruby/blob/main/api_generator%2Flib%2Faction.rb |
Signed-off-by: Kim Quang Cap <kimquangcap@gmail.com>
Oh, right! Thanks for guiding me @Earlopain @dblock |
Description
Script Score query was added to OpenSearch 2.9 and current query DSL does not support it.
This PR add script_score to query DSL.
Issues Resolved
#253
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.