[Feature/extensions] Modified Environment settings support #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceptionHandling Signed-off-by: Joshua Palis <jpalis@amazon.com>
…sponse handler syncronously Signed-off-by: Joshua Palis <jpalis@amazon.com>
Merged
6 tasks
dbwiddis
requested changes
Oct 11, 2022
src/main/java/org/opensearch/sdk/handlers/EnvironmentSettingsResponseHandler.java
Show resolved
Hide resolved
src/main/java/org/opensearch/sdk/handlers/EnvironmentSettingsResponseHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/sdk/handlers/EnvironmentSettingsResponseHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/sdk/handlers/EnvironmentSettingsResponseHandler.java
Show resolved
Hide resolved
Signed-off-by: Joshua Palis <jpalis@amazon.com>
owaiskazi19
reviewed
Oct 11, 2022
src/main/java/org/opensearch/sdk/handlers/EnvironmentSettingsResponseHandler.java
Outdated
Show resolved
Hide resolved
…andler Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
force-pushed
the
main
branch
3 times, most recently
from
f2399fb to
6eab1a5
Compare
ryanbogan
previously approved these changes
Oct 12, 2022
owaiskazi19
previously approved these changes
Oct 12, 2022
Signed-off-by: Joshua Palis <jpalis@amazon.com>
joshpalis
dismissed stale reviews from owaiskazi19, ryanbogan, and dbwiddis
via
d9ec172
owaiskazi19
approved these changes
Oct 12, 2022
ryanbogan
approved these changes
Oct 12, 2022
|
Hey @joshpalis I just noticed the following in some gradle checks:
Can you please add that |
|
@dbwiddis Sure thanks for catching that, I'll make sure to add this |
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
…h-project#179) * modified environment settings request to use sendGenericRequestWithExceptionHandling Signed-off-by: Joshua Palis <jpalis@amazon.com> * modified sendEnvironmentRequest to return the Settings object from response handler syncronously Signed-off-by: Joshua Palis <jpalis@amazon.com> * addressing PR comments Signed-off-by: Joshua Palis <jpalis@amazon.com> * addressing PR comments, moving countdown latch creation to response handler Signed-off-by: Joshua Palis <jpalis@amazon.com> * adding missing javadocs Signed-off-by: Joshua Palis <jpalis@amazon.com> Signed-off-by: Joshua Palis <jpalis@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Environment Settings support for extensibility will now pass the entire Settings object from OpenSearch node environment to the SDK.
Companion PR : opensearch-project/OpenSearch#4731
Issues Resolved
#78
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.