-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copyright line to license headers #196
Conversation
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
I should probably make changes to the
|
You can use a smaller license header, while you are doing so I'd recommend the tiny one [1] [2]
[1] opensearch-project/OpenSearch#4657 |
We should wait for gradle check to run on this PR before merging it. |
Flipping this to draft to discuss @peternied comment. I went searching everywhere for that official guidance, and it's very confusing. Why is the contributing document not up to date with the guidance in this comment from @AMoo-Miki? What is the scope of "like this one" mentioned in that comment? Where is the official guidance if not at the CONTRIBUTING link cited above? |
I believe the guidance linked by @peternied is outdated as of opensearch-project/.github#76 which updated to the version I'm using. I filed an issue to request final clarification: opensearch-project/.github#98 |
Gradle check ran, but you can't see it. 😁 See #197 so that stops happening. I think the header is the correct one and this PR will stand as-is, but will wait for confirmation on the above issue I filed before flipping this back to review. Only need one spammy header update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dan for taking care of this!
@joshpalis I don't think Dan wanted this merged yet. Maybe next time we should add a |
* Delete unnecessary netty licenses missed in opensearch-project#76 Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add copyright line to license header Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add copyright to headers via spotlessApply Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com>
Description
Adds copyright line to conform license header to format per https://github.com/opensearch-project/.github/blob/main/CONTRIBUTING.md#java
Issues Resolved
Fixes #194
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.