Properly initialize SDKClient actions map #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
requested review from
joshpalis,
owaiskazi19,
ryanbogan and
saratvemulapalli
as code owners
owaiskazi19
previously approved these changes
Mar 3, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
owaiskazi19
reviewed
Mar 3, 2023
owaiskazi19
previously approved these changes
Mar 3, 2023
owaiskazi19
reviewed
Mar 3, 2023
src/test/java/org/opensearch/sdk/sample/helloworld/TestHelloWorldExtension.java
Outdated
Show resolved
Hide resolved
joshpalis
approved these changes
Mar 3, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #520 +/- ##
============================================
+ Coverage 66.98% 67.26% +0.27%
- Complexity 188 191 +3
============================================
Files 35 35
Lines 833 840 +7
Branches 25 25
============================================
+ Hits 558 565 +7
Misses 264 264
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
owaiskazi19
approved these changes
Mar 3, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 3, 2023
* Properly initialize SDKClient actions map Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add null check and more useful exception message Signed-off-by: Daniel Widdis <widdis@gmail.com> * Typo Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit da6f35f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Mar 3, 2023
* Properly initialize SDKClient actions map * Add null check and more useful exception message * Typo --------- (cherry picked from commit da6f35f) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
* Properly initialize SDKClient actions map Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add null check and more useful exception message Signed-off-by: Daniel Widdis <widdis@gmail.com> * Typo Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 19, 2023
* Properly initialize SDKClient actions map Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add null check and more useful exception message Signed-off-by: Daniel Widdis <widdis@gmail.com> * Typo Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Nurym <nurym0807@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an
initialize()method to theSDKClientto allow itsactionsmap to be populated after Guice injection, even though the class was instantiated before. This is the same pattern used withNodeClientthat we are emulating.In addition, maintains a field for the Guice
Injectorin theExtensionsRunner. It was getting garbage collected and losing its usefulness, particularly in Rest Handlers.Issues Resolved
Fixes #519
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.