Updated DEV guide with the new initialization api #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19
requested review from
joshpalis,
ryanbogan,
saratvemulapalli and
dbwiddis
as code owners
dbwiddis
reviewed
Jun 12, 2023
|
@kolchfa-aws not able to add you as a reviewer, so tagging here for a review. Thanks! |
kolchfa-aws
approved these changes
Jun 12, 2023
owaiskazi19
force-pushed
the
initialize-extensions-api
branch
from
242612b to
d618a71
Compare
ryanbogan
reviewed
Jun 13, 2023
dbwiddis
previously approved these changes
Jun 14, 2023
joshpalis
previously approved these changes
Jun 14, 2023
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19
force-pushed
the
initialize-extensions-api
branch
from
d618a71 to
17c327d
Compare
joshpalis
approved these changes
Jun 15, 2023
ryanbogan
approved these changes
Jun 19, 2023
|
LGTM! Waiting to merge until the companion PR is in |
|
Companion PR is in! |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 22, 2023
* Updated DEV guide with the new initialization api Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Addressed PR comments Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> (cherry picked from commit bef933f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jun 22, 2023
* Updated DEV guide with the new initialization api * Addressed PR comments --------- (cherry picked from commit bef933f) Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Companion PR for: opensearch-project/OpenSearch#8029
Issues Resolved
Part of #782
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.