empty implementation for OS deleteIndexMetadata

Signed-off-by: Sean Kao <seankao@amazon.com>
opensearch-project · Aug 6, 2024 · 9fdac45 · 9fdac45
1 parent f07289c
commit 9fdac45
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...rc/main/scala/org/opensearch/flint/core/storage/FlintOpenSearchIndexMetadataService.scala b/...rc/main/scala/org/opensearch/flint/core/storage/FlintOpenSearchIndexMetadataService.scala
@@ -90,6 +90,7 @@ class FlintOpenSearchIndexMetadataService(options: FlintOptions)
     }
   }
 
+  // Do nothing. For OpenSearch, deleting the index will also delete its metadata
   override def deleteIndexMetadata(indexName: String): Unit = {}
 }
 

diff --git a/flint-spark-integration/src/main/scala/org/opensearch/flint/spark/FlintSpark.scala b/flint-spark-integration/src/main/scala/org/opensearch/flint/spark/FlintSpark.scala
@@ -17,7 +17,6 @@ import org.opensearch.flint.common.metadata.log.OptimisticTransaction.NO_LOG_ENT
 import org.opensearch.flint.core.{FlintClient, FlintClientBuilder}
 import org.opensearch.flint.core.metadata.FlintIndexMetadataServiceBuilder
 import org.opensearch.flint.core.metadata.log.FlintMetadataLogServiceBuilder
-import org.opensearch.flint.core.storage.FlintOpenSearchIndexMetadataService
 import org.opensearch.flint.spark.FlintSparkIndex.ID_COLUMN
 import org.opensearch.flint.spark.FlintSparkIndexOptions.OptionName._
 import org.opensearch.flint.spark.covering.FlintSparkCoveringIndex
@@ -278,7 +277,7 @@ class FlintSpark(val spark: SparkSession) extends FlintSparkTransactionSupport w
           .finalLog(_ => NO_LOG_ENTRY)
           .commit(_ => {
             flintClient.deleteIndex(indexName)
-            // TODO: delete index metadata
+            flintIndexMetadataService.deleteIndexMetadata(indexName)
             true
           })
       } else {
-Original file line number
+Diff line change
@@ Expand Up @@
         }
       }
+      // Do nothing. For OpenSearch, deleting the index will also delete its metadata
       override def deleteIndexMetadata(indexName: String): Unit = {}
     }
@@ Expand Down @@