Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Preserve dots in table name when generate index name #106

Closed
dai-chen opened this issue Oct 26, 2023 · 2 comments
Closed

[BUG] Preserve dots in table name when generate index name #106

dai-chen opened this issue Oct 26, 2023 · 2 comments
Assignees
Labels
0.1.1 bug Something isn't working

Comments

@dai-chen
Copy link
Collaborator

What is the bug?

Currently Flint replaces all dots in qualified table name with underscore. However, this doesn't align with PPL.

Flint:

https://github.com/opensearch-project/opensearch-spark/blob/main/flint-spark-integration/src/main/scala/org/opensearch/flint/spark/FlintSparkIndex.scala#L91

PPL:

https://github.com/opensearch-project/sql/blob/main/spark/src/test/java/org/opensearch/sql/spark/flint/IndexQueryDetailsTest.java#L67

What is the expected behavior?

Modify the generate index name logic and align with PPL behavior.

@dai-chen dai-chen added bug Something isn't working untriaged labels Oct 26, 2023
@dai-chen dai-chen self-assigned this Oct 26, 2023
@dai-chen dai-chen added 0.1.1 and removed untriaged labels Oct 26, 2023
@dai-chen dai-chen moved this from Todo to In Progress in OpenSearch Spark Project Planning Nov 2, 2023
@dai-chen dai-chen moved this from In Progress to Todo in OpenSearch Spark Project Planning Nov 2, 2023
@dai-chen dai-chen moved this from Todo to In Progress in OpenSearch Spark Project Planning Nov 3, 2023
@dai-chen dai-chen moved this from In Progress to Under Review in OpenSearch Spark Project Planning Nov 4, 2023
@Swiddis
Copy link
Contributor

Swiddis commented Nov 7, 2023

Also seems to be behind a bug in integrations, we haven't accounted for the underscore replacement which causes issues in finding materialized views for table names with dots.

@dai-chen
Copy link
Collaborator Author

dai-chen commented Nov 7, 2023

Also seems to be behind a bug in integrations, we haven't accounted for the underscore replacement which causes issues in finding materialized views for table names with dots.

Here is the naming convention for your reference: https://github.com/opensearch-project/opensearch-spark/blob/main/docs/index.md#opensearch

@dai-chen dai-chen moved this from Under Review to Done in OpenSearch Spark Project Planning Nov 7, 2023
@dai-chen dai-chen closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.1.1 bug Something isn't working
Development

No branches or pull requests

2 participants