Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flint index name and MV name bug #127

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented Nov 3, 2023

Description

This PR fixed 2 bugs with regard to index naming:

  1. [BUG] Show materialized view returns full name in single column #105 : only return MV name in SHOW MV statement rather than fully qualified MV name, e.g. mv_test instead of spark_catalog.default.mv_test. This aligns with show tables statement and show MV statement in other databases.
  2. [BUG] Preserve dots in table name when generate index name #106 : handle table name with dots in the same way as PPL plugin, e.g. previously for MV on table spark_catalog.default.test.2023.10, Flint index name will be flint_spark_catalog_default_test_2023_10, now change it to flint_spark_catalog_default_test.2023.10 to align with PPL. Ref: Add where clause support in create statement sql#2366

Issues Resolved

#105, #106

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen added the bug Something isn't working label Nov 3, 2023
@dai-chen dai-chen self-assigned this Nov 3, 2023
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen marked this pull request as ready for review November 4, 2023 01:00
@dai-chen dai-chen merged commit 19ad190 into opensearch-project:main Nov 7, 2023
4 checks passed
@dai-chen dai-chen deleted the fix-mv-name-bug branch November 7, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants