Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Flint version to 0.3.0 #258

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Feb 20, 2024

Description

Bump Flint current version to 0.3.0 in main branch

Testing
Version in artifact name:

$ sbt clean assembly
$ find . -name "*-0.3.0-SNAPSHOT.jar"
./spark-sql-application/target/scala-2.12/sql-job-assembly-0.3.0-SNAPSHOT.jar
./flint-spark-integration/target/scala-2.12/flint-spark-integration-assembly-0.3.0-SNAPSHOT.jar
./ppl-spark-integration/target/scala-2.12/ppl-spark-integration-assembly-0.3.0-SNAPSHOT.jar

Version in Flint index metadata (currently version field represents Flint code version. We can add another field specVersion for specification version as needed):

./bin/spark-sql --jars /Users/penghuo/oss/opensearch-spark/flint-spark-integration/target/scala-2.12/flint-spark-integration-assembly-0.3.0-SNAPSHOT.jar --conf spark.sql.extensions=org.opensearch.flint.spark.FlintSparkExtensions

{
  "flint_spark_catalog_default_http_logs_full_skipping_index": {
    "aliases": {},
    "mappings": {
      "_meta": {
        "latestId": "ZmxpbnRfc3BhcmtfY2F0YWxvZ19kZWZhdWx0X2h0dHBfbG9nc19mdWxsX3NraXBwaW5nX2luZGV4",
        "kind": "skipping",
        "indexedColumns": [
          {
            "columnType": "int",
            "kind": "VALUE_SET",
            "parameters": {
              "max_size": "100"
            },
            "columnName": "status"
          }
        ],
        "name": "flint_spark_catalog_default_http_logs_full_skipping_index",
        "options": {
          "auto_refresh": "false",
          "incremental_refresh": "false"
        },
        "source": "spark_catalog.default.http_logs_full",
        "version": "0.3.0",
        "properties": {}
      },
      "properties": {
        "file_path": {
          "type": "keyword"
        },
        "status": {
          "type": "integer"
        }
      }
    }
  }
}

Issues Resolved

#254

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo marked this pull request as ready for review February 20, 2024 19:33
@penghuo penghuo self-assigned this Feb 20, 2024
@@ -19,6 +19,7 @@ Version compatibility:
|---------------|-------------|---------------|---------------|------------|
| 0.1.0 | 11+ | 3.3.1 | 2.12.14 | 2.6+ |
| 0.2.0 | 11+ | 3.3.1 | 2.12.14 | 2.6+ |
| 0.3.0 | 11+ | 3.3.2 | 2.12.14 | 2.6+ |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, shall we also mention compatibility with the SQL plugin? Assume we will delete the query parameter from the main entry point args.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point,
does it impact 0.2.0, or only for 0.3.0?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 0.2 has already been released, we can do 0.3.
SQL change - opensearch-project/sql#2519
Flint change - #253

@penghuo penghuo merged commit faa0d07 into opensearch-project:main Feb 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants