Improve flint error handling #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noCharger
force-pushed
the
improve-err
branch
3 times, most recently
from
ae48ce8 to
e24c398
Compare
noCharger
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
noCharger
force-pushed
the
improve-err
branch
2 times, most recently
from
c54be0c to
bd1fc2e
Compare
seankao-az
reviewed
May 10, 2024
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintJobExecutor.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Louis Chu <clingzhi@amazon.com>
penghuo
reviewed
May 10, 2024
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintJobExecutor.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Louis Chu <clingzhi@amazon.com>
penghuo
approved these changes
May 10, 2024
vmmusings
approved these changes
May 10, 2024
Signed-off-by: Louis Chu <clingzhi@amazon.com>
seankao-az
approved these changes
May 11, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.3 0.3
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.3
# Create a new branch
git switch --create backport/backport-335-to-0.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 45835cb27407166669f660cc665436ed6cc93200
# Push it to GitHub
git push --set-upstream origin backport/backport-335-to-0.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.3Then, create a pull request where the |
noCharger
added a commit
that referenced
this pull request
May 11, 2024
* Improve flint error handling Signed-off-by: Louis Chu <clingzhi@amazon.com> * Error field in json format Signed-off-by: Louis Chu <clingzhi@amazon.com> * Superset update Signed-off-by: Louis Chu <clingzhi@amazon.com> --------- Signed-off-by: Louis Chu <clingzhi@amazon.com> (cherry picked from commit 45835cb)
noCharger
added a commit
that referenced
this pull request
May 11, 2024
* Improve flint error handling Signed-off-by: Louis Chu <clingzhi@amazon.com> * Error field in json format Signed-off-by: Louis Chu <clingzhi@amazon.com> * Superset update Signed-off-by: Louis Chu <clingzhi@amazon.com> --------- Signed-off-by: Louis Chu <clingzhi@amazon.com> (cherry picked from commit 45835cb)
noCharger
added a commit
that referenced
this pull request
May 11, 2024
| case r: AnalysisException => | ||
| Some(r.getServiceName), | ||
| Some(r.getStatusCode)) | ||
| case r: AWSGlueException => |
There was a problem hiding this comment.
Can we also add handling for permission errors to S3, OpenSearch as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve flint error handling
handleQueryExceptionIssues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.