Read dataSourceName from FlintOptions and avoid passing as args
#378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seankao-az
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo,
anirudha,
kaituo and
YANG-DB
as code owners
Signed-off-by: Sean Kao <seankao@amazon.com>
seankao-az
force-pushed
the
read-datasource-from-option
branch
from
ef90dcd to
63ce65c
Compare
seankao-az
changed the title
FlintOptions and avoid passing as args
noCharger
approved these changes
Jun 11, 2024
dai-chen
approved these changes
Jun 11, 2024
seankao-az
added a commit
to seankao-az/opensearch-spark
that referenced
this pull request
Aug 9, 2024
…t#378) Signed-off-by: Sean Kao <seankao@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
dataSourceNamefrom args and read from options instead.Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.