Remove unimplemented syntax #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykmr1224
force-pushed
the
unavailable-commands
branch
8 times, most recently
from
23efc45 to
3b4a57e
Compare
ykmr1224
changed the title
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
ykmr1224
force-pushed
the
unavailable-commands
branch
from
3b4a57e to
a0f1fd7
Compare
ykmr1224
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
noCharger
approved these changes
Jul 23, 2024
YANG-DB
approved these changes
Jul 23, 2024
Some commands had implementation which throws error, so I referred them first. I found some more unimplemented ones, and I verified those syntax fails by running it in test. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
* Remove unimplemented syntax Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Fix keywordsCanBeId and statsFunctionName Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Remove describe and show datasources Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Fix indent Signed-off-by: Tomoyuki Morita <moritato@amazon.com> --------- Signed-off-by: Tomoyuki Morita <moritato@amazon.com> (cherry picked from commit 3e964be) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dai-chen
pushed a commit
that referenced
this pull request
Jul 29, 2024
* Remove unimplemented syntax * Fix keywordsCanBeId and statsFunctionName * Remove describe and show datasources * Fix indent --------- (cherry picked from commit 3e964be) Signed-off-by: Tomoyuki Morita <moritato@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.