Add OpenSearchTable in flint core #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penghuo
changed the title
10 tasks
penghuo
requested review from
dai-chen,
rupal-bq,
vamsimanohar,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
penghuo
changed the title
dai-chen
reviewed
Jul 26, 2024
flint-core/src/main/java/org/opensearch/flint/core/RestHighLevelClientWrapper.java
Outdated
Show resolved
Hide resolved
flint-spark-integration/src/main/scala/org/apache/spark/sql/flint/FlintScanBuilder.scala
Outdated
Show resolved
Hide resolved
...n/src/test/scala/org/opensearch/flint/spark/covering/ApplyFlintSparkCoveringIndexSuite.scala
Outdated
Show resolved
Hide resolved
flint-core/src/main/scala/org/opensearch/flint/core/table/OpenSearchIndexTable.scala
Outdated
Show resolved
Hide resolved
flint-core/src/main/scala/org/opensearch/flint/core/table/OpenSearchIndexTable.scala
Outdated
Show resolved
Hide resolved
flint-core/src/main/scala/org/opensearch/flint/core/storage/FlintOpenSearchClient.java
Outdated
Show resolved
Hide resolved
Comment on lines
+123
to
+126
| val SUPPORT_SHARD = FlintConfig(s"spark.datasource.flint.${FlintOptions.SUPPORT_SHARD}") | ||
| .datasourceOption() | ||
| .doc("indicate does index support shard or not") | ||
| .createWithDefault(String.valueOf(FlintOptions.DEFAULT_SUPPORT_SHARD)) |
There was a problem hiding this comment.
Is this new option for testing or some use case? Does this actually mean if the OpenSearch table is partitioned or not?
There was a problem hiding this comment.
This describes whether the OpenSearch index supports sharding. The reason is that OpenSearch serverless does not support sharding.
Currently, a table's partition is determined by the partition, but there is no hard limit.
There was a problem hiding this comment.
Ideally, we should remove this setting. However, currently, the AOSS index settings return shard information, so we cannot distinguish it.
{
"settings": {
"index": {
"number_of_shards": "2",
"number_of_replicas": "0",
}
}
}
}
Signed-off-by: Peng Huo <penghuo@gmail.com>
dai-chen
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SELECT COUNT(*) FROM dev.default.logs-181998SELECT COUNT(*) FROM dev.default.logs-181998 WHERE status <> 0SELECT COUNT(*), AVG(size) FROM dev.default.logs-181998SELECT AVG(CAST(size AS BIGINT)) FROM dev.default.logs-181998SELECT MIN(@timestamp), MAX(@timestamp) FROM dev.default.logs-181998SELECT status, COUNT() FROM dev.default.logs-181998 WHERE status <> 0 GROUP BY status ORDER BY COUNT() DESCIssues Resolved
#494
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.