[Backport 0.5] Abstract service for accessing Flint index metadata #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* fix missed renames
* rename for log entry properties
* correct typo planTransformer
Signed-off-by: Sean Kao <seankao@amazon.com>
* add FlintIndexMetadataService
* interface class for FlintIndexMetadataService
* move FlintMetadata and FlintVersion to flint-commons
* remove ser/de from FlintMetadata; move to OS impl for
FlintIndexMetadataService
* remove schema parser in FlintMetadata builder to remove dependency to
opensearch
* FlintSparkIndex generate not only schema json but also map
* FlintMetadataSuite divided into two: one for builder and one for
ser/de, which is merged to FlintOpenSearchIndexMetadataServiceSuite
Signed-off-by: Sean Kao <seankao@amazon.com>
* move get metadata functions to new service
* Remove getIndexMetadata and getAllIndexMetadata from FlintClient
* Implement the two for OpenSearch
* TODO: sanitize index name
* Add builder for FlintIndexMetadataService and options
* Refactor caller of FlintClient.get(All)IndexMetadata with
FlintIndexMetadataService
* TODO: test suite for getIndexMetadata and getAllIndexMetadata (might
overlap with FlintOpenSearchClientSuite)
Signed-off-by: Sean Kao <seankao@amazon.com>
* update index metadata
* remove updateIndex from FlintClient
* implement updateIndexMetadata for FlintOpenSearchIndexMetadataService
* updateIndexMetadata upon create index in FlintSpark
* for OS client + OS index metadata service, the call for update is
redundant
* it's for when some other index metadata service implementation is
provided
* TODO: Suite for updateIndexMetadata (now shared with
FlintOpenSearchClientSuite)
Signed-off-by: Sean Kao <seankao@amazon.com>
* empty implementation for OS deleteIndexMetadata
Signed-off-by: Sean Kao <seankao@amazon.com>
* sanitize index name
Signed-off-by: Sean Kao <seankao@amazon.com>
* fix new FlintOption missing from FlintSparkConf
Signed-off-by: Sean Kao <seankao@amazon.com>
* fix FlintOpenSearchClientSuite
Signed-off-by: Sean Kao <seankao@amazon.com>
* delete file (missed in resolving conflict)
Signed-off-by: Sean Kao <seankao@amazon.com>
* Use service builder in OpenSearchCluster
Signed-off-by: Sean Kao <seankao@amazon.com>
* fix service builder class
* fix FlintOptions for custom class spark properties
* remove SparkConf from builder argument
Signed-off-by: Sean Kao <seankao@amazon.com>
* fix IT
Signed-off-by: Sean Kao <seankao@amazon.com>
* add test suites
Signed-off-by: Sean Kao <seankao@amazon.com>
* sanitize index name for opensearch metadata log
Signed-off-by: Sean Kao <seankao@amazon.com>
* remove spark-warehouse files
Signed-off-by: Sean Kao <seankao@amazon.com>
* exclude _meta field for createIndex in OpenSearch
Signed-off-by: Sean Kao <seankao@amazon.com>
* catch client creation exception
Signed-off-by: Sean Kao <seankao@amazon.com>
* Fetch metadata for OpenSearch table
* OpenSearchCluster move to java file because scala object cannot be
mocked in mockito
Signed-off-by: Sean Kao <seankao@amazon.com>
* update doc with spark config
Signed-off-by: Sean Kao <seankao@amazon.com>
---------
Signed-off-by: Sean Kao <seankao@amazon.com>
(cherry picked from commit f5ad574)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
seankao-az
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport f5ad574 from #495.