Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query execution metrics #799

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

ykmr1224
Copy link
Collaborator

Description

  • Add query execution metrics
  • batch.processingTime: execution duration for batch query.
  • query.execution.processingTime: Duration from start to complete query (excluding writing result)

Metrics-CloudWatch-us-west-2-10-21-2024_04_28_PM

Related Issues

n/a

Check List

  • Updated documentation (docs/ppl-lang/README.md)
  • Implemented unit tests
  • Implemented tests for combination with other commands
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Copy link
Collaborator

@seankao-az seankao-az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the dimensions of these metrics?

@ykmr1224
Copy link
Collaborator Author

What are the dimensions of these metrics?

Same as current ones (default ones coming from config). Might add datasource type later.

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
@noCharger noCharger merged commit 7546f58 into opensearch-project:main Oct 23, 2024
4 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 29, 2024
* Add query execution metrics

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Remove batch.processingTime metrics

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

---------

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
(cherry picked from commit 7546f58)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
seankao-az pushed a commit that referenced this pull request Oct 29, 2024
* Add query execution metrics



* Remove batch.processingTime metrics



---------


(cherry picked from commit 7546f58)

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kenrickyap pushed a commit to Bit-Quill/opensearch-spark that referenced this pull request Dec 11, 2024
* Add query execution metrics

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Remove batch.processingTime metrics

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

---------

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants