Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkpoint.delete.processingTime metric #817

Merged

Conversation

ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Oct 25, 2024

Description

  • Add checkpoint.delete.processingTime metric

Tested in my test cluster
checkpoint delete processingTime

Related Issues

n/a

Check List

  • Updated documentation (docs/ppl-lang/README.md)
  • Implemented unit tests
  • Implemented tests for combination with other commands
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Copy link
Collaborator

@seankao-az seankao-az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve with non-blocking minor comment

@ykmr1224 ykmr1224 merged commit 341eacb into opensearch-project:main Oct 25, 2024
4 checks passed
@ykmr1224 ykmr1224 deleted the metrics/checkpoint_delete branch October 25, 2024 23:31
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 30, 2024
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
(cherry picked from commit 341eacb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
seankao-az pushed a commit that referenced this pull request Oct 30, 2024
(cherry picked from commit 341eacb)

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kenrickyap pushed a commit to Bit-Quill/opensearch-spark that referenced this pull request Dec 11, 2024
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants