PR coverage requirement and default settings #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
saratvemulapalli
approved these changes
Jul 18, 2022
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #3931 +/- ##
============================================
+ Coverage 70.46% 70.60% +0.14%
- Complexity 56600 56691 +91
============================================
Files 4557 4563 +6
Lines 272737 272755 +18
Branches 40040 40040
============================================
+ Hits 192188 192584 +396
+ Misses 64324 63912 -412
- Partials 16225 16259 +34
Continue to review full report at Codecov.
|
kotwanikunal
approved these changes
Jul 18, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2022
Signed-off-by: Suraj Singh <surajrider@gmail.com> (cherry picked from commit 1020852)
dreamer-89
added a commit
that referenced
this pull request
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Suraj Singh surajrider@gmail.com
Description
Add PR code coverage requirement and default settings. Used
70%coverage based on existing coverage which is just above 70%.As an improvement, project specific status checks can be added. For e.g.
server/which contains the core logic should have strict rules and separate status checks.Issues Resolved
#1324
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.