-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x]Support task resource tracking in OpenSearch (#3982) #4087
[Backport 2.x]Support task resource tracking in OpenSearch (#3982) #4087
Conversation
Gradle Check (Jenkins) Run Completed with:
|
77a5124
to
930ba7c
Compare
Failed in |
Gradle Check (Jenkins) Run Completed with:
|
* Support task resource tracking in OpenSearch * Reopens changes from opensearch-project#2639 (reverted in opensearch-project#3046) to add a framework for task resource tracking. Currently, SearchTask and SearchShardTask support resource tracking but it can be extended to any other task. * Fixed a race-condition when Task is unregistered before its threads are stopped * Improved error handling and simplified task resource tracking completion listener * Avoid registering listeners on already completed tasks Signed-off-by: Ketan Verma <ketan9495@gmail.com>
930ba7c
to
991632b
Compare
The Jenkins' build succeeded, but the GitHub action while trying to get the job status failed. |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #4087 +/- ##
==========================================
Coverage 70.61% 70.62%
- Complexity 56628 56687 +59
==========================================
Files 4543 4545 +2
Lines 272332 272525 +193
Branches 40017 40037 +20
==========================================
+ Hits 192307 192461 +154
+ Misses 63902 63865 -37
- Partials 16123 16199 +76
Help us with your feedback. Take ten seconds to tell us how you rate us. |
[Backport 2.x] Support task resource tracking in OpenSearch (#3982)
Support task resource tracking in OpenSearch
Reopens changes from Support task resource tracking in OpenSearch #2639 (reverted in Revert "Support task resource tracking in OpenSearch" #3046) to add a framework for task resource tracking. Currently, SearchTask and SearchShardTask support resource tracking but it can be extended to any other task.
Fixed a race-condition when Task is unregistered before its threads are stopped
Improved error handling and simplified task resource tracking completion listener
Avoid registering listeners on already completed tasks
Signed-off-by: Ketan Verma ketan9495@gmail.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.