[Backport 1.x] [OSCI] Clean/breadcrumb updates - Refactoring use of 'let' for 'const' keyword and CSS modifier '--last' for one class only #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…' keyword and CSS modifier '--last' for one class only (#1144) * refactoring changing 'let' variables with 'const' Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com> * refactoring changing 'let' variables with 'const' Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com> * refactoring _breadcrumbs.sccs, removing '--last' modifier from .ouiBreadcrumb class, keeping it only in .ouiBreadcrumbWrapper class Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com> * refactoring _breadcrumbs.sccs, removing '--last' modifier from .ouiBreadcrumb class, keeping it only in .ouiBreadcrumbWrapper class Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com> * updating CHANGELOG.md file Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com> * fixing calculation of calculatedMax, breadcrumbs.tsx, line 310 Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com> * updating breadcrumbs JSX according suggestion from maintainer for better readability of code Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com> --------- Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com> Signed-off-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 064a02c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
AMoo-Miki
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 064a02c from #1144.