-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use faster animations for modals, popovers, and tooltips #1282
Merged
ashwin-pc
merged 4 commits into
opensearch-project:main
from
virajsanghvi:lnf-animation
Jul 10, 2024
Merged
feat: use faster animations for modals, popovers, and tooltips #1282
ashwin-pc
merged 4 commits into
opensearch-project:main
from
virajsanghvi:lnf-animation
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
virajsanghvi
requested review from
AMoo-Miki,
rednaksi91,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
June 26, 2024 20:40
bandinib-amzn
approved these changes
Jul 10, 2024
ashwin-pc
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate the detailed PR description
Signed-off-by: Viraj Sanghvi <vsanghvi@gmail.com>
Signed-off-by: Viraj Sanghvi <vsanghvi@gmail.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
* feat: use faster animations for modals, popovers, and tooltips Signed-off-by: Viraj Sanghvi <virajs@amazon.com> * Update changelog Signed-off-by: Viraj Sanghvi <virajs@amazon.com> --------- Signed-off-by: Viraj Sanghvi <virajs@amazon.com> Signed-off-by: Viraj Sanghvi <vsanghvi@gmail.com> (cherry picked from commit 3556698) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
AMoo-Miki
pushed a commit
that referenced
this pull request
Jul 12, 2024
#1289) * feat: use faster animations for modals, popovers, and tooltips Signed-off-by: Viraj Sanghvi <virajs@amazon.com> * Update changelog Signed-off-by: Viraj Sanghvi <virajs@amazon.com> --------- Signed-off-by: Viraj Sanghvi <virajs@amazon.com> Signed-off-by: Viraj Sanghvi <vsanghvi@gmail.com> (cherry picked from commit 3556698) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase animation speed/behavior for modals, popovers, and tooltips
fyi: @lauralexis
Issues Resolved
N/A
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.