Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use faster animations for modals, popovers, and tooltips #1282

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

virajsanghvi
Copy link
Collaborator

@virajsanghvi virajsanghvi commented Jun 26, 2024

Description

Increase animation speed/behavior for modals, popovers, and tooltips

Component Before After
Modals modal before modal after
Popovers popover before popover after
Tooltips tooltip before tooltip after

fyi: @lauralexis

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate the detailed PR description

Signed-off-by: Viraj Sanghvi <vsanghvi@gmail.com>
Signed-off-by: Viraj Sanghvi <vsanghvi@gmail.com>
@ashwin-pc ashwin-pc merged commit 3556698 into opensearch-project:main Jul 10, 2024
18 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 10, 2024
* feat: use faster animations for modals, popovers, and tooltips

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>

* Update changelog

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>

---------

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Signed-off-by: Viraj Sanghvi <vsanghvi@gmail.com>
(cherry picked from commit 3556698)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
AMoo-Miki pushed a commit that referenced this pull request Jul 12, 2024
#1289)

* feat: use faster animations for modals, popovers, and tooltips

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>

* Update changelog

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>

---------

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Signed-off-by: Viraj Sanghvi <vsanghvi@gmail.com>
(cherry picked from commit 3556698)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants