Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport 1.x] Introduce compressed appearance for OuiSuperDatePicker (#1307) #1321

Merged

Conversation

AMoo-Miki
Copy link
Collaborator

Backport c3c02d5 from #1307

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…oject#1307)

Also:
* Sync changelog
* Add compressed SuperDatePicker internal component

Signed-off-by: Miki <miki@amazon.com>

(cherry picked from commit c3c02d5)
Signed-off-by: Miki <miki@amazon.com>
Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason i18ntokens.json changes didn't make it here?

@AMoo-Miki
Copy link
Collaborator Author

is there a reason i18ntokens.json changes didn't make it here?

Not sure. I will do a build and see if a change is needed and PR it individually.

Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving assuming i18ntokens issue is followed up on separately

@AMoo-Miki AMoo-Miki merged commit 3713d5a into opensearch-project:1.x Aug 2, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants