Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updates to v9 colors, button/input styles, and typography #1373

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

virajsanghvi
Copy link
Collaborator

@virajsanghvi virajsanghvi commented Aug 25, 2024

Description

This makes updates to the v9 theme, including:

  • Adding dark theme colors
  • Adjusting existing link colors to match primary colors
  • Removing shadows from inputs/buttons by defalt
  • Adding shows on hover for inputs
  • Correcting super date picker to use primary text color instead of link color to match empty button usage
Item Screenshot (v9) Screenshot (v7)
Super Date Picker image image
Form Components (default) image
Input hover image
Buttons (default) image
Empty buttons (default) image
Button Icon (default) image
Button groups (defeault) image
Ghost buttons (default) image
Split button (default) image
Switch image

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
@virajsanghvi virajsanghvi merged commit 1e69cc8 into opensearch-project:main Aug 27, 2024
14 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 27, 2024
* fix: Updates to v9 colors, button/input styles, and typography

---------

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
(cherry picked from commit 1e69cc8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
virajsanghvi added a commit to virajsanghvi/oui that referenced this pull request Aug 27, 2024
…earch-project#1373)

* fix: Updates to v9 colors, button/input styles, and typography

---------

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
(cherry picked from commit 1e69cc8)
virajsanghvi added a commit that referenced this pull request Aug 27, 2024
#1377)

* fix: Updates to v9 colors, button/input styles, and typography

---------

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
(cherry picked from commit 1e69cc8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants