Create OuiSimplifiedBreadcrumbs and update OuiHeaderBreadcrumbs #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
requested review from
AMoo-Miki,
rednaksi91,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak,
SergeyMyssak and
virajsanghvi
as code owners
zhongnansu
force-pushed
the
simplified-breadcrumbs
branch
from
d8a16f4
to
d6d329b
Compare
7 tasks
zhongnansu
force-pushed
the
simplified-breadcrumbs
branch
from
d6d329b
to
ef583c1
Compare
| const classes = classNames( | ||
| 'ouiHeaderBreadcrumbs', | ||
| { | ||
| 'ouiHeaderBreadcrumbs--simplified': simplify, |
There was a problem hiding this comment.
is this needed here or should this just be in the component itself?
There was a problem hiding this comment.
yes, it's needed here, to make use of the existing class generator. ouiHeaderBreadcrumbs--simplified is added to apply the spacing for the new breadcrumbs
| margin-right: $ouiBreadcrumbSpacing; | ||
| width: 2px; | ||
| height: $ouiSize; | ||
| transform: translateY(-1px) rotate(15deg); |
There was a problem hiding this comment.
Is this a pre-existing implementation of the slashes?
There was a problem hiding this comment.
yes, taken from the code in oui 1.1
|
Can you add a changelog entry? |
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
zhongnansu
force-pushed
the
simplified-breadcrumbs
branch
from
ef583c1
to
a39c001
Compare
added |
virajsanghvi
approved these changes
Aug 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
Signed-off-by: Zhongnan Su <szhongna@amazon.com> (cherry picked from commit 2c0c73c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create OuiSimplifiedBreadcrumbs and update OuiHeaderBreadcrumbs
Issues Resolved
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.