Adjust OuiSimplifiedBreadcrumbs alignment, colors, and tailing slash #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
bandinib-amzn,
ashwin-pc,
joshuarrrr and
virajsanghvi
as code owners
AMoo-Miki
force-pushed
the
adjust-breadcrumbs
branch
from
d12e1c4
to
135d567
Compare
AMoo-Miki
force-pushed
the
adjust-breadcrumbs
branch
4 times, most recently
from
3fd1b46
to
b0d6a96
Compare
AMoo-Miki
added a commit
to AMoo-Miki/oui
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
force-pushed
the
adjust-breadcrumbs
branch
from
b0d6a96
to
2f39b2b
Compare
AMoo-Miki
added a commit
to AMoo-Miki/oui
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
force-pushed
the
adjust-breadcrumbs
branch
from
2f39b2b
to
f2117cb
Compare
There was a problem hiding this comment.
Do you know why this doesn't match oui website?
your changes: 
https://oui.opensearch.org/1.12/#/navigation/breadcrumbs:
Also, are failures related?
AMoo-Miki
added a commit
to AMoo-Miki/oui
that referenced
this pull request
Sep 18, 2024
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
force-pushed
the
adjust-breadcrumbs
branch
from
2bcd9ff
to
1c9e11d
Compare
Two changes impact this:
|
AMoo-Miki
force-pushed
the
adjust-breadcrumbs
branch
from
1c9e11d
to
d59d847
Compare
…s in OuiSimplifiedBreadcrumbs Also: * Adjust alignments, colors, and separator in OuiSimplifiedBreadcrumbs * Add documentation for OuiSimplifiedBreadcrumbs * Add CSS breakpoints to OuiBreakpointSize Signed-off-by: Miki <miki@amazon.com>
Also: * Correctly color the OuiBreadcrumbs when focused * Display the last breadcrumb in a nested breadcrumb as a normal breadcrumb Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Also: * Limit allowed breakpoints to those provided by the `responsive` prop of Oui*Breadcrumbs Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
force-pushed
the
adjust-breadcrumbs
branch
from
d59d847
to
c633cb8
Compare
virajsanghvi
approved these changes
Sep 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
…1401) * Add methods to control the appearance of trailing and last breadcrumbs in OuiSimplifiedBreadcrumbs Also: * Adjust alignments, colors, and separator in OuiSimplifiedBreadcrumbs * Add documentation for OuiSimplifiedBreadcrumbs * Add CSS breakpoints to OuiBreakpointSize Signed-off-by: Miki <miki@amazon.com> * Remove the unwanted OuiBreadcrumbs focus rectangle Also: * Correctly color the OuiBreadcrumbs when focused * Display the last breadcrumb in a nested breadcrumb as a normal breadcrumb Signed-off-by: Miki <miki@amazon.com> * Update changelog for #1401 Signed-off-by: Miki <miki@amazon.com> * Allow limiting the allowed breakpoints when calling `getBreakpoint()` Also: * Limit allowed breakpoints to those provided by the `responsive` prop of Oui*Breadcrumbs Signed-off-by: Miki <miki@amazon.com> * Adjust number of responsive breadcrumbs shown per breakpoint Signed-off-by: Miki <miki@amazon.com> * Update snapshots Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit fd5b78a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
AMoo-Miki
pushed a commit
that referenced
this pull request
Sep 18, 2024
…1401) (#1409) * Add methods to control the appearance of trailing and last breadcrumbs in OuiSimplifiedBreadcrumbs Also: * Adjust alignments, colors, and separator in OuiSimplifiedBreadcrumbs * Add documentation for OuiSimplifiedBreadcrumbs * Add CSS breakpoints to OuiBreakpointSize Signed-off-by: Miki <miki@amazon.com> * Remove the unwanted OuiBreadcrumbs focus rectangle Also: * Correctly color the OuiBreadcrumbs when focused * Display the last breadcrumb in a nested breadcrumb as a normal breadcrumb Signed-off-by: Miki <miki@amazon.com> * Update changelog for #1401 Signed-off-by: Miki <miki@amazon.com> * Allow limiting the allowed breakpoints when calling `getBreakpoint()` Also: * Limit allowed breakpoints to those provided by the `responsive` prop of Oui*Breadcrumbs Signed-off-by: Miki <miki@amazon.com> * Adjust number of responsive breadcrumbs shown per breakpoint Signed-off-by: Miki <miki@amazon.com> * Update snapshots Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit fd5b78a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add methods to control the appearance of trailing and last breadcrumbs in OuiSimplifiedBreadcrumbs
Also:
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.