Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.0] Disable spellcheck on password field #147

Merged
merged 1 commit into from
Dec 14, 2022
Merged

[Backport 1.0] Disable spellcheck on password field #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/components/form/field_password/__snapshots__/field_password.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ exports[`OuiFieldPassword is rendered 1`] = `
id="1"
name="elastic"
placeholder="Placeholder"
spellcheck="false"
type="password"
value="1"
/>
Expand Down Expand Up @@ -46,6 +47,7 @@ exports[`OuiFieldPassword props compressed is rendered 1`] = `
<oui-validatable-control>
<input
class="ouiFieldPassword ouiFieldPassword--compressed"
spellcheck="false"
type="password"
/>
</oui-validatable-control>
Expand Down Expand Up @@ -76,6 +78,7 @@ exports[`OuiFieldPassword props dual dual type also renders append 1`] = `
<oui-validatable-control>
<input
class="ouiFieldPassword ouiFieldPassword--inGroup ouiFieldPassword--withToggle"
spellcheck="false"
type="password"
/>
</oui-validatable-control>
Expand Down Expand Up @@ -129,6 +132,7 @@ exports[`OuiFieldPassword props dual dualToggleProps is rendered 1`] = `
<oui-validatable-control>
<input
class="ouiFieldPassword ouiFieldPassword--inGroup ouiFieldPassword--withToggle"
spellcheck="false"
type="password"
/>
</oui-validatable-control>
Expand Down Expand Up @@ -173,6 +177,7 @@ exports[`OuiFieldPassword props fullWidth is rendered 1`] = `
<oui-validatable-control>
<input
class="ouiFieldPassword ouiFieldPassword--fullWidth"
spellcheck="false"
type="password"
/>
</oui-validatable-control>
Expand Down Expand Up @@ -205,6 +210,7 @@ exports[`OuiFieldPassword props isInvalid is rendered 1`] = `
>
<input
class="ouiFieldPassword"
spellcheck="false"
type="password"
/>
</oui-validatable-control>
Expand Down Expand Up @@ -235,6 +241,7 @@ exports[`OuiFieldPassword props isLoading is rendered 1`] = `
<oui-validatable-control>
<input
class="ouiFieldPassword ouiFieldPassword-isLoading"
spellcheck="false"
type="password"
/>
</oui-validatable-control>
Expand Down Expand Up @@ -277,6 +284,7 @@ exports[`OuiFieldPassword props prepend and append is rendered 1`] = `
<oui-validatable-control>
<input
class="ouiFieldPassword ouiFieldPassword--inGroup"
spellcheck="false"
type="password"
/>
</oui-validatable-control>
Expand Down Expand Up @@ -312,6 +320,7 @@ exports[`OuiFieldPassword props type dual is rendered 1`] = `
<oui-validatable-control>
<input
class="ouiFieldPassword ouiFieldPassword--inGroup ouiFieldPassword--withToggle"
spellcheck="false"
type="password"
/>
</oui-validatable-control>
Expand Down Expand Up @@ -355,6 +364,7 @@ exports[`OuiFieldPassword props type password is rendered 1`] = `
<oui-validatable-control>
<input
class="ouiFieldPassword"
spellcheck="false"
type="password"
/>
</oui-validatable-control>
Expand Down Expand Up @@ -385,6 +395,7 @@ exports[`OuiFieldPassword props type text is rendered 1`] = `
<oui-validatable-control>
<input
class="ouiFieldPassword"
spellcheck="false"
type="text"
/>
</oui-validatable-control>
Expand Down
1 change: 1 addition & 0 deletions src/components/form/field_password/field_password.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ export const OuiFieldPassword: FunctionComponent<OuiFieldPasswordProps> = ({
value={value}
ref={setInputRef}
{...rest}
spellCheck="false"
/>
</OuiValidatableControl>
</OuiFormControlLayout>
Expand Down