fix: overlay mask onClick been called multiple times #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cause: `click` event listener is not properly unsubscribed Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
BSFishy
approved these changes
Jan 30, 2023
ananzh
approved these changes
Feb 28, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
The cause: `click` event listener is not properly unsubscribed Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit b945c86) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
seanneumann
added a commit
that referenced
this pull request
Feb 28, 2023
The cause: `click` event listener is not properly unsubscribed (cherry picked from commit b945c86) Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause:
clickevent listener is not properly unsubscribedSigned-off-by: Yulong Ruan ruanyl@amazon.com
Description
The issue:
The
onClickevent handler will be called multiple times if theonClickinstance changed among different rendering.Here is branch to reproduce it: main...ruanyl:oui:overlay-mask-bug-reproduce
You can find the
onClickfunction is called the same times as the times the button been clicked.Issues Resolved
[List any issues this PR will resolve]
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.