Add icons for Dashboards 2.7 #658

BSFishy · 2023-04-04T00:46:45Z

Description

Add the icons that are needed for Dashboards 2.7. A few items of cleanup needed to happen. Namely:

Add SPDX header
Indent paths
Remove fills on paths
Re-order svg tag
Remove fill on svg tag

Issues Resolved

Closes #628

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Matt Provost <provomat@amazon.com>

KrooshalUX · 2023-04-04T01:25:35Z

Can you attach a screenshot of the docs site with the icons added for UX sign off? :D

BSFishy · 2023-04-04T16:50:31Z

Can you attach a screenshot of the docs site with the icons added for UX sign off? :D

I took screenshots but forgot to attach them :P updated the PR 👍

kgcreative · 2023-04-05T05:38:04Z

I'm wondering if instead of visBuilderPPL we should say visPPL?

BSFishy · 2023-04-05T16:13:51Z

I'm wondering if instead of visBuilderPPL we should say visPPL?

I mainly just copied the naming convention of the files that were supplied. Can change any names if needed 👍

kgcreative · 2023-04-05T16:45:56Z

@KrooshalUX - can you comment on naming?

KrooshalUX · 2023-04-05T17:08:54Z

@kgcreative Since that structure was already being used for visType, I wanted to give it another name category, since these are "ways to build a visualization" - an issue regarding clarity that we are battling in multiple places right now. This naming convention also helps keep them grouped together on the OUI Icons documentation page , vs scattered between chart types - is already fairly hard to scan through the icon page.

However, if you feel strongly about removing the "builder" part from here, that is fine - I don't really feel that strongly about it.

kgcreative · 2023-04-05T17:48:11Z

I think my main concern on naming is making sure we weren't conflating this with the visBuilder project icons, since these are primarily there to help support the observability visualizations. I'm open to other names.

KrooshalUX · 2023-04-05T19:09:42Z

Please leave visBuilder, and visBuilderSavedObject as is (note: I wouldnt normally call out SavedObject in an icon name, but we needed a level of clarity for this round and use in the icon set. I was recommending a 1:1 use of the icon to the saved object, but in case that is not possible, we created a fall back. I would prefer to clean this up during our Data Explorer project)

Please change:
visBuilderDQL to visQueryDQL (this probably wont get used, but it was supplied in case)
visBuilderPPL to visQueryPPL
visBuilderSQL to visQuerySQL
visBuilderPromQL to visQueryPromQL

Signed-off-by: Matt Provost <provomat@amazon.com>

AMoo-Miki · 2023-04-07T17:41:45Z

src/components/icon/assets/vis_builder.svg

We will revisit this later.

For context: this svg file is 32x33 rather than 32x32. We're trying to push this out for 2.7, so we'll fix this in a later update and just focus on getting this PR through right now

Is there an issue tracking?

Strange, sorry about that. I will correct and re-export when I am back at my desk.

Signed-off-by: Matt Provost <provomat@amazon.com>

BSFishy · 2023-04-07T19:48:17Z

@kgcreative need final UX review

KrooshalUX

LGTM

* Add icons Signed-off-by: Matt Provost <provomat@amazon.com> * Rename icons to correct name Signed-off-by: Matt Provost <provomat@amazon.com> * Update svg copyright header Signed-off-by: Matt Provost <provomat@amazon.com> --------- Signed-off-by: Matt Provost <provomat@amazon.com> Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com> (cherry picked from commit 9e18194) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Add icon * Rename icons to correct name * Update svg copyright header --------- (cherry picked from commit 9e18194) Signed-off-by: Matt Provost <provomat@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>

* Add icons * Rename icons to correct name * Update svg copyright header --------- (cherry picked from commit 9e18194) Signed-off-by: Matt Provost <provomat@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>

Add icons

487e34d

Signed-off-by: Matt Provost <provomat@amazon.com>

BSFishy added the backport 1.x label Apr 4, 2023

BSFishy requested a review from a team as a code owner April 4, 2023 00:46

KrooshalUX mentioned this pull request Apr 5, 2023

Add icons to icon pack #628

Closed

8 tasks

seanneumann and others added 3 commits April 5, 2023 13:18

Merge branch 'main' into add_icons

e0c5bfb

Rename icons to correct name

a03f8c9

Signed-off-by: Matt Provost <provomat@amazon.com>

Merge branch 'add_icons' of github.com:BSFishy/oui into add_icons

dc4448c

Signed-off-by: Matt Provost <provomat@amazon.com>

BSFishy added the backport 1.1 label Apr 6, 2023

AMoo-Miki reviewed Apr 7, 2023

View reviewed changes

Update svg copyright header

8a3a9e3

Signed-off-by: Matt Provost <provomat@amazon.com>

BSFishy requested review from seanneumann, rednaksi91, KrooshalUX and bandinib-amzn as code owners April 7, 2023 17:54

AMoo-Miki approved these changes Apr 7, 2023

View reviewed changes

Merge branch 'main' into add_icons

6191717

seanneumann approved these changes Apr 7, 2023

View reviewed changes

KrooshalUX approved these changes Apr 7, 2023

View reviewed changes

BSFishy merged commit 9e18194 into opensearch-project:main Apr 7, 2023

opensearch-trigger-bot bot mentioned this pull request Apr 7, 2023

[Backport 1.x] Add icons for Dashboards 2.7 #684

Merged

opensearch-trigger-bot bot mentioned this pull request Apr 7, 2023

[Backport 1.1] Add icons for Dashboards 2.7 #685

Merged

joshuali925 mentioned this pull request Apr 13, 2023

Refactor Saved objects and add visualization embeddable opensearch-project/dashboards-observability#341

Merged

6 tasks

joshuarrrr mentioned this pull request Sep 1, 2023

Add icons for OSD 2.10 release #1014

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add icons for Dashboards 2.7 #658

Add icons for Dashboards 2.7 #658

BSFishy commented Apr 4, 2023 •

edited

Loading

KrooshalUX commented Apr 4, 2023

BSFishy commented Apr 4, 2023

kgcreative commented Apr 5, 2023

BSFishy commented Apr 5, 2023

kgcreative commented Apr 5, 2023

KrooshalUX commented Apr 5, 2023 •

edited

Loading

kgcreative commented Apr 5, 2023

KrooshalUX commented Apr 5, 2023 •

edited

Loading

AMoo-Miki Apr 7, 2023

BSFishy Apr 7, 2023

seanneumann Apr 7, 2023

KrooshalUX Apr 7, 2023

BSFishy commented Apr 7, 2023

KrooshalUX left a comment

Add icons for Dashboards 2.7 #658

Add icons for Dashboards 2.7 #658

Conversation

BSFishy commented Apr 4, 2023 • edited Loading

Description

Issues Resolved

Check List

KrooshalUX commented Apr 4, 2023

BSFishy commented Apr 4, 2023

kgcreative commented Apr 5, 2023

BSFishy commented Apr 5, 2023

kgcreative commented Apr 5, 2023

KrooshalUX commented Apr 5, 2023 • edited Loading

kgcreative commented Apr 5, 2023

KrooshalUX commented Apr 5, 2023 • edited Loading

AMoo-Miki Apr 7, 2023

Choose a reason for hiding this comment

BSFishy Apr 7, 2023

Choose a reason for hiding this comment

seanneumann Apr 7, 2023

Choose a reason for hiding this comment

KrooshalUX Apr 7, 2023

Choose a reason for hiding this comment

BSFishy commented Apr 7, 2023

KrooshalUX left a comment

Choose a reason for hiding this comment

BSFishy commented Apr 4, 2023 •

edited

Loading

KrooshalUX commented Apr 5, 2023 •

edited

Loading

KrooshalUX commented Apr 5, 2023 •

edited

Loading