Refactors changes related to demo configuration #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
requested review from
khushbr,
ansjcy and
sbcd90
as code owners
2 tasks
1 similar comment
ansjcy
approved these changes
Feb 6, 2024
atharvasharma61
approved these changes
Feb 6, 2024
bbarani
approved these changes
Feb 6, 2024
|
@khushbr @praveensameneni @sbcd90 @ansjcy Can you please check the errors on CI checks and merge the PR if they are expected? |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com> (cherry picked from commit a8a8365)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were recent changes to security demo configuration setup which now requires a custom admin Password to be setup. This PR updates the documentation and related code change.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.