Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test report and code coverage upload #739

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Oct 23, 2024

Description

This PR fixes uploads to codecov and general uploads of artifacts to Github. While working on #736, I noticed that uploads were hitting the rate limit and failing.

==> Uploading reports
    url: https://codecov.io
    query: branch=main&commit=c643111d76f63eadd5fe1196844f96a84df530bb&build=11[47](https://github.com/opensearch-project/performance-analyzer/actions/runs/11473403760/job/31927585948#step:9:48)3403760&build_url=https%3A%2F%2Fgithub.com%2Fopensearch-project%2Fperformance-analyzer%2Factions%2Fruns%2F11473403760&name=&tag=&slug=opensearch-project%2Fperformance-analyzer&service=github-actions&flags=&pr=&job=Java+CI&cmd_args=f
->  Pinging Codecov
https://codecov.io//upload/v4?package=bash-1.0.6&token=<hidden>&package=bash-1.0.6&token=&branch=main&commit=c643111d76f63eadd5fe1196844f96a84df530bb&build=11473403760&build_url=https%3A%2F%2Fgithub.com%2Fopensearch-project%2Fperformance-analyzer%2Factions%2Fruns%2F11473403760&name=&tag=&slug=opensearch-project%2Fperformance-analyzer&service=github-actions&flags=&pr=&job=Java+CI&cmd_args=f
{"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2501s."}
{"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2[49](https://github.com/opensearch-project/performance-analyzer/actions/runs/11473403760/job/31927585948#step:9:50)9s."}
{"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2497s."}
{"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2495s."}
{"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2492s."}
{"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2490s."}

This PR changes the upload step to use the GHA for uploading to codecov.

Workflow where it failed: https://github.com/opensearch-project/performance-analyzer/actions/runs/11473403760/job/31927585948

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Gaganjuneja
Gaganjuneja previously approved these changes Oct 23, 2024
@Gaganjuneja
Copy link
Collaborator

Waiting for builds to complete.

@cwperks
Copy link
Member Author

cwperks commented Oct 23, 2024

Upload still failed. Looking into it.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks changed the title Fix code coverage upload Fix test report and code coverage upload Oct 23, 2024
@Gaganjuneja Gaganjuneja merged commit 77fdbaa into opensearch-project:main Oct 23, 2024
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 23, 2024
* Fix code coverage upload

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Update path

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 77fdbaa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants