Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encoding check workflow to ensure all the files having utf-8 encoding and vale continue-on-error #2700

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Apr 2, 2024

Description

Add encoding check workflow to ensure all the files having utf-8 encoding and vale continue-on-error

Issues Resolved

Closes #2699
opensearch-project/documentation-website#6722

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

…ding

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
kolchfa-aws
kolchfa-aws previously approved these changes Apr 2, 2024
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon changed the title Add encoding check workflow to ensure all the files having utf-8 encoding Add encoding check workflow to ensure all the files having utf-8 encoding and value continue-on-error Apr 2, 2024
@kolchfa-aws kolchfa-aws merged commit 8fc3b67 into opensearch-project:main Apr 2, 2024
5 checks passed
@peterzhuamazon peterzhuamazon deleted the Add-utf8-checker branch April 2, 2024 19:37
@peterzhuamazon peterzhuamazon changed the title Add encoding check workflow to ensure all the files having utf-8 encoding and value continue-on-error Add encoding check workflow to ensure all the files having utf-8 encoding and vale continue-on-error Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflows
Projects
Development

Successfully merging this pull request may close these issues.

[Enhancement] Ensure non-binary files are using utf-8 encoding
2 participants